SportPaper icon indicating copy to clipboard operation
SportPaper copied to clipboard

Reintroduce carpet patch with a config

Open Anchor5178 opened this issue 3 years ago • 5 comments

Since https://github.com/Electroid/SportPaper/commit/923ff1fac5ec3446edd3474b8f4c891b6226ea11 was reverted with https://github.com/Electroid/SportPaper/commit/5b5762f87c9a7dfb1f93b9ee251318cc1e75ce1d this issue is existing again.

This could be easily fixed by making https://github.com/Electroid/SportPaper/blob/master/patches/server/0191-Prevent-1.7-players-glitching-in-carpet.patch toggleable via the config.

Only AAC5 users have to disable this patch. AAC5 does not even support 1.7 so AAC5 users do not need this patch.

Anchor5178 avatar Mar 28 '21 14:03 Anchor5178

Or maybe you can use ViaVersion API to know if the player is using 1.7.

linsaftw avatar Apr 25 '21 20:04 linsaftw

I do not understand how that should fix this issue since pure 1.8 servers are affected by it even though they do not need it.

Anchor5178 avatar Apr 28 '21 09:04 Anchor5178

I do not understand how that should fix this issue since pure 1.8 servers are affected by it even though they do not need it.

Didn't it only affect 1.7 clients?

linsaftw avatar Apr 28 '21 14:04 linsaftw

No, it also affects 1.8 players since the carpet height is set to 0 for all players.

Anchor5178 avatar Apr 28 '21 14:04 Anchor5178

With the patch, the hitbox is handled client-side, if you set it to 0 all players can freely walk on it, 1.7 players (due to their client) will be on y=0, and 1.8+ players will (again, due to their client) walk on y=0.0625.

The complaint is some anticheats will not treat this properly

Pablete1234 avatar Apr 29 '21 00:04 Pablete1234