Wizardry icon indicating copy to clipboard operation
Wizardry copied to clipboard

Snare Spell Oddity and Crashes with OptiFine

Open Ghostrider231 opened this issue 6 years ago • 7 comments

Minecraft version: 1.12.2 Wizardry version: 4.1.1

Issue details:

No Other Mods Installed just this mod Only issue: Whenever a Mob activates the snare trap you've casted beforehand: the particle effects gets rendered on you instead of the mob that activated the snare trap. (I don't know If posting a separate issue for this one is necessary or not)


(yes, Optifine is the culprit for this crash unfortunately)

Opifine installed issue -Crash-: Whenever a Mob activates the snare trap: the game will crash resulting in a Rendering Particle -1 crash.

Reproducing:

  1. Get a Snare spell, scroll or wand doesn't matter which.
  2. Cast the Snare Spell on the ground. (You can cast as many as you want)
  3. Get a Mob Spawn egg. (I go for slimes because their sizes varies)
  4. Spawn the mob on top of the trap or have it walk onto it.
  5. If Optifine is installed, the game will crash. Or If it isn't Installed, the particle effects gets rendered on the player/caster instead of the mob that walked on the snare trap.

Using internal shaders does make the crash happen a little later. But using no shaders makes it happen instantly, which is what's happening.

Other mods involved: Just Optifine.


Crash Report (been cut to important bits): https://pastebin.com/1P6cDw0L (client-side crash)

Uncommonly or Rarely I'll get this problem too: https://pastebin.com/DKu4wPhJ (server crash)

Ghostrider231 avatar Apr 16 '18 01:04 Ghostrider231

Okay, these might be linked so leave them in the same issue for now. The non-Optifine issue sounds like a pretty easy fix so I'll deal with that first. If that fixes the Optifine issue as well, great; if not you can make a separate issue for that afterwards.

Electroblob77 avatar Apr 22 '18 11:04 Electroblob77

I have been able to reproduce this, but only by casting the snare spell directly under a mob's feet. If I cast it and then have a mob walk onto it, the block breaking particles don't get rendered at all. I suspect this may be a syncing issue. Closer inspection of the crash report tells me that the block breaking particles are trying to access blocks with a chunk coordinate of -1, which doesn't exist, so I think the client is getting the position of the block incorrectly.

Electroblob77 avatar Jun 03 '18 11:06 Electroblob77

I've managed to trace this down to SPacketEffect, somehow the BlockPos for the block breaking sound/particles is entered on the server side as the position of the snare but is retrieved on the client side as the position of the player. I have no idea why this is happening and it's not happening in wizardry's code either.

Electroblob77 avatar Jun 05 '18 12:06 Electroblob77

I have this issue but instead of Optifine there's BetterFPS installed. I just tried running the pack with out BetterFPS and it's still crashing the server. Is there any workaround to kill the snare?

toolongtospell avatar Jan 03 '19 14:01 toolongtospell

Is there any workaround to kill the snare?

You might be able to use /fill, /setblock or worldedit to get rid of it, or if you can't load the world you could open it in an external editor.

Electroblob77 avatar Jan 04 '19 23:01 Electroblob77

Hello just checked in with the latest version (4.2.11) and tried snare again and I've noticed the crash doesn't occur anymore.

However, the snare effect is still rendered on the caster/player instead of the one who activated it.

Ghostrider231 avatar Jun 05 '20 21:06 Ghostrider231

Good to know, d6b64b3 must have fixed the crash then. I'll leave this issue open so I remember to look at the rendering weirdness.

Electroblob77 avatar Jul 28 '20 09:07 Electroblob77