ElectricalAge icon indicating copy to clipboard operation
ElectricalAge copied to clipboard

Cable quality update

Open OmegaHaxors opened this issue 6 years ago • 11 comments

Adds Resistive dust, which replaces the function of coal dust in resistors. Crafts from coal dust in a ratio of 1:8

Improved the power draw of 200V machines to 1,000 so they're actually worth the upgrade cost

Added custom registering system for cables which cleans up the code plenty. This also adds 3 new types of Cable Quality: Shoddy with half capacity, Quality with double capacity, and Perfect with 10x the capacity.

Renamed 'normal' cables to Standard cables to be consistant with the naming scheme of the new cables

Complex crafting chain to make Pure Copper, used to craft Quality cables. (Known issue: The bucket and lead is consumed in the process)

Glorious Copper which requires excessive folding of Pure Copper which makes Perfect Cables.

Turrets track faster and cost more to run passively, no longer target dead enemies, remark "gotcha" upon killing an enemy, and generally are better at aiming and killing their targets

Batteries are cheaper to recycle and have realistic battery capacity Life Batteries have higher resistance so they are no longer a direct upgrade

Added recipe to macerate silicon from flint

OmegaHaxors avatar Feb 05 '19 20:02 OmegaHaxors

Apologies, I should have tested to see if it compiled before attempting to push the update. Since you had removed CableRSFactor yet some of my code still used it, I simply removed any reference to it and now things should work properly.

OmegaHaxors avatar Feb 05 '19 21:02 OmegaHaxors

Did a lot of compatibility changes. It compiles now and I haven't noticed any errors.

OmegaHaxors avatar Feb 05 '19 21:02 OmegaHaxors

I hope you've liked the changes I did to the wire registry, I worked really hard on it

OmegaHaxors avatar Feb 13 '19 03:02 OmegaHaxors

Given what it was, massive improvement

On Tue, Feb 12, 2019, 10:06 PM OmegaHaxors <[email protected] wrote:

I hope you've liked the changes I did to the wire registry, I worked really hard on it

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Electrical-Age/ElectricalAge/pull/896#issuecomment-463038187, or mute the thread https://github.com/notifications/unsubscribe-auth/AL5CDbbT6smlta1tLQNFqU3_GbJA7m1Rks5vM4EigaJpZM4akDHT .

Castone22 avatar Feb 13 '19 04:02 Castone22

Your code also failed the Travis build because you're not using the new functions Baugh set up for those pesky variables we had problems with a few weeks back.

jrddunbr avatar Feb 13 '19 11:02 jrddunbr

That should address any issue that were had.

OmegaHaxors avatar Feb 13 '19 12:02 OmegaHaxors

I will need help with one bit though, the localization on the new cables seems to fail and i'm not quite sure why.

OmegaHaxors avatar Feb 13 '19 12:02 OmegaHaxors

Confirmed now not to cause any regressions when updating. That said, this feature pack won't contain any of the newer things (such as the arcmetal/clay blocks) so make sure you have those in there when building.

OmegaHaxors avatar Feb 13 '19 14:02 OmegaHaxors

EDIT: Alright that should be everything taken care of. Just have to test everything and make sure there isn't any issues, then I will push the update and it will be ready for merging.

OmegaHaxors avatar Feb 16 '19 15:02 OmegaHaxors

Thank you for being patient, that should be everything.

OmegaHaxors avatar Feb 16 '19 17:02 OmegaHaxors

Alright I think that's everything.

OmegaHaxors avatar Feb 19 '19 14:02 OmegaHaxors