ElectricalAge
ElectricalAge copied to clipboard
Dimension IDs are not bytes
At https://github.com/Electrical-Age/ElectricalAge/blob/3e7db53eac084b4f2770139949630d01f72a8767/src/main/java/mods/eln/node/NodeBase.java#L464, and probably other places, dimension IDs are treated as bytes.
This manifests as blocks being invisible client-side in any dimension with ID above 127, which can happen fairly easily on any server with dimension-creating mods such as Dimensional Doors, Tardis, rftools, ...
There's no reason to be this stingy with the bandwidth, so let's make all four coordinate elements ints. A varint, perhaps.
The codebase should be audited to make sure that the same pattern isn't repeated elsewhere.
Last time I checked I believe the WAILA support treated it as a size 5 int, so we should be good there. Not sure about anywhere else though.