zashi-android
zashi-android copied to clipboard
Wrap necessary code fragments to SideEffect
Is your feature request related to a problem? Please describe.
As came up from code review comments, we'd like to wrap several code fragments into the Compose SideEffect
to avoid unnecessary calls from the related Compose.
Describe the solution you'd like
E.g. wrap logging using our Twig
components into SideEffect to eliminate its unnecessary triggers.
We should go through the code base and address this logic to other occurrences as well.
Alternatives you've considered
Creating Twig Composable extension to provide us with a composable logging alternative for such cases.
Additional context
Review comments:
- https://github.com/Electric-Coin-Company/zashi-android/pull/1476#discussion_r1644709236
- https://github.com/Electric-Coin-Company/zashi-android/pull/1476#discussion_r1644709982
- https://github.com/Electric-Coin-Company/zashi-android/pull/1476#discussion_r1644716127