electionguard icon indicating copy to clipboard operation
electionguard copied to clipboard

🐞 SchnorrProof challenge specification and implementation do not match

Open JohnLCaron opened this issue 2 years ago • 1 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Current Behavior

Specification 1.0 for SchnorrProof (p 10, p 27) has the challenge as

c i,j = H(Q, K i,j , h i,j )

But implementation make_schnorr_proof in schnorr.py. line 89 has

c = hash_elems(k, h)

This was discussed in

https://github.com/microsoft/electionguard-python/issues/278

and it was decided to leave out the Q.

Expected Behavior

The specification should be amended after reviewing the decision to leave out the Q.

Steps To Reproduce

No response

Environment

- OS:

Anything else?

The 2.0 document being circulated "Proofs in ElectionGuard– changes for version 2.0" section 2 should also be amended.

JohnLCaron avatar Apr 13 '22 13:04 JohnLCaron

CC @benaloh

keithrfung avatar May 13 '22 14:05 keithrfung