electionguard-python icon indicating copy to clipboard operation
electionguard-python copied to clipboard

♻️ Migrate CLI print methods to single module

Open keithrfung opened this issue 2 years ago • 4 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Suggestion

To improve the CLI and be a bit more pythonic, migrate the common click to echo to a more aptly named module. Ideally, this should contain the references to click.echo to a single module, but the closest to this is best.

Possible Implementation

Create a print_utils.py file in the electionguard_cli to be used for all print functionality. These should all be methods and no classes should be necessary. This should allow the deletion of e2estepbase.py

Suggested items to migrate: https://github.com/microsoft/electionguard-python/blob/03698c683ab35f608e35dc9b66217caa1d40f7eb/src/electionguard_cli/e2e_steps/input_retrieval_step.py#L42 https://github.com/microsoft/electionguard-python/blob/03698c683ab35f608e35dc9b66217caa1d40f7eb/src/electionguard_cli/e2e_steps/e2e_step_base.py#L14 https://github.com/microsoft/electionguard-python/blob/03698c683ab35f608e35dc9b66217caa1d40f7eb/src/electionguard_cli/e2e_steps/e2e_step_base.py#L19

https://github.com/microsoft/electionguard-python/blob/03698c683ab35f608e35dc9b66217caa1d40f7eb/src/electionguard_cli/e2e_steps/print_results_step.py#L13

Anything else?

No response

keithrfung avatar Apr 19 '22 21:04 keithrfung

Hello my name is Antonio and I would like to contribute to this issue along with my two peers, Pedro and Justice.

Alopezjr2002 avatar Jul 06 '22 00:07 Alopezjr2002

Hey, I'm Pedro Rangel, and I will be part of the team.

CodingForFun-coder avatar Jul 06 '22 00:07 CodingForFun-coder

Hello my name is Justice and I would like to help contribute to this issue along with Antonio, and Pedro.

JKnight777 avatar Jul 06 '22 00:07 JKnight777

welcome @JKnight777 @CodingForFun-coder and @Alopezjr2002 welcome aboard! Please have at it and use this issue for any questions and comments. I'll also send you invites to the Democracy Forward slack

rc-ms avatar Jul 06 '22 00:07 rc-ms