Distribt icon indicating copy to clipboard operation
Distribt copied to clipboard

convert sync dependy creation to async

Open AlexScigalszky opened this issue 2 years ago • 3 comments

AlexScigalszky avatar Dec 02 '22 19:12 AlexScigalszky

There is an option that is to add the suffix "Async" to all those methods that need to be asynchronous. I'm not well-oriented to that approach but it's an option to respond to your concern about "await" uses.

Speaking of your issue with dotnet build looks like you need to run dotnet restore. At least I couldn't reproduce that error. Maybe if you tell more details I can fix it

AlexScigalszky avatar Feb 06 '24 19:02 AlexScigalszky

There is an option that is to add the suffix "Async" to all those methods that need to be asynchronous. I'm not well-oriented to that approach but it's an option to respond to your concern about "await" uses.

Speaking of your issue with dotnet build looks like you need to run dotnet restore. At least I couldn't reproduce that error. Maybe if you tell more details I can fix it

nah, forget about using async, the task one gives an error if it does not get awaited, that should be enough.

Let me know when you finish and I will review again.

ElectNewt avatar Feb 08 '24 20:02 ElectNewt

@ElectNewt I finish and it runs completely on my machine 😄

AlexScigalszky avatar Feb 19 '24 20:02 AlexScigalszky