Cronus icon indicating copy to clipboard operation
Cronus copied to clipboard

Rename ICommandHander and IEventHandler

Open mynkow opened this issue 5 years ago • 2 comments

ICommandHandler<T> and IEventHandler<T> are actually handles. We have to rename them as follows:

  • ICommandHandler<T> => ICommandHandle<T>
  • IEventHandler<T> => IEventHandle<T>

mynkow avatar May 02 '20 20:05 mynkow

I do not agree with this change due to the following reasons:

  • Breaking change due to this being a public class and is commonly used
  • Interfaces should denote behavior of a class
    • ex. I need a handler for commands, thus, a class which is a CommandHandler.

AlexPlom avatar Oct 15 '20 10:10 AlexPlom

A handle is something that you would use to reference a block of memory. The handle would provide you with a high level api over that memory. This change is unnecessary and misleading imo. https://en.wikipedia.org/wiki/Handle_(computing)#:~:text=In%20computer%20programming%2C%20a%20handle,database%20or%20an%20operating%20system.

ethno2405 avatar Oct 17 '20 07:10 ethno2405