Mustafa Elbehery

Results 87 comments of Mustafa Elbehery

> @Elbehery as we discussed in the community meeting, please read the membership guide as mentioned in [#116 (comment)](https://github.com/etcd-io/gofail/pull/116#issuecomment-2966459529) (also mentioned above by @serathius ) > > For the gofail...

> @Elbehery, we don't have a `shellcheck` CI check here (yet). Can you run shellcheck on your script? I believe there are a couple of instances where it will give...

the last run after updates ``` melbeher@melbeher-mac bbolt % ./scripts/release.sh version_20250212 enter release string according to semantic versioning (e.g. v1.2.3). v1.4.0-beta.15 fatal: a branch named 'version_20250212' already exists Updating version...

@ivanvc am i missing anything here ?

hello will update tonight, really lost track of it :'(

> > Sorry for the late response. @ivanvc is this PR good to go? > > No, we're missing changes from the last batch of comments. The script, as it...

@ivanvc updated 👍🏽 PTAL

Hello ✋🏽 I have just tested this, find the output below ``` ./scripts/release.sh version_20250518 enter release string according to semantic versioning (e.g. v1.2.3). v1.4.0-beta.15 fatal: a branch named 'version_20250518' already...

@ivanvc updated, now everything happens in the `release-{MINOR}` branch see below run of current script ``` ./scripts/release.sh enter release string according to semantic versioning (e.g. v1.2.3). v1.4.0-beta.15 Switched to a...