TagListView icon indicating copy to clipboard operation
TagListView copied to clipboard

Custom tag views

Open raysarebest opened this issue 6 years ago • 3 comments

This provides a fix for Issue #142. This moves the applying of default stylings from a factory method in TagListView that's called in addTag(_:) to a method that just handles styling and is called in addTagView(_:) and insertTagView(_:at:). I also changed the implementation of addTagViews(_:) to call out to addTagView(_:) for each individual tag. Ultimately, this allows for the easy addition of custom subclasses to TagView. I added documentation comments for each of the relevant methods to make it clear that they unconditionally apply the styling of the TagListView that the TagView/subclass is being added to, so any individual tag stylization should take place after calling addTagView(_:), addTagViews(_:), or insertTagView(_:at:)

raysarebest avatar Sep 05 '17 09:09 raysarebest

👍 to the PR would love to see this one merged!

FKSI avatar Sep 21 '17 12:09 FKSI

@anti-transmission when do you think it will be release? :)

FKSI avatar Sep 26 '17 11:09 FKSI

I just pushed some commits to fix the previous merge conflicts with the latest master branch, so I'd really love to see this get merged/released sometime soon (cc: @csvenja @Cee @xhacker @anti-transmission)

raysarebest avatar Aug 05 '19 04:08 raysarebest