vite_ruby icon indicating copy to clipboard operation
vite_ruby copied to clipboard

Use Vite4 or Vite5 manifests, not both

Open KieranP opened this issue 1 year ago • 6 comments

Description 📖

This fixes an issue where upgrading to Vite5 was merging old Vite4 and Vite5 manifests together, creating JS errors.

Background 📜

This was happening because vite_ruby was merging vite4 and vite5 manifests together.

The Fix 🔨

Check for Vite5 manifests. If present, use those, otherwise fall back to Vite4 manifests.

Amends #420

KieranP avatar Jan 23 '24 19:01 KieranP

I'm going through the same problem.

rgioia avatar Feb 07 '24 00:02 rgioia

I just upgraded to Vite 5 and am dealing with this now as well.

emptyflask avatar Feb 23 '24 01:02 emptyflask

Hey @ElMassimo , is there anything that needs to be done here before this can be merged?

benlangfeld avatar Jul 10 '24 16:07 benlangfeld

@ElMassimo we're eager to see this merged. Is there anything we can do to help?

sbastn avatar Jul 25 '24 12:07 sbastn

@ElMassimo Could this please be merged and included in the next release?

benlangfeld avatar Aug 12 '24 16:08 benlangfeld

Is there anything we can do to help with getting this released?

rmehner avatar Aug 14 '24 08:08 rmehner