Mongoid 9 support

[danarnold]

trafficstars

Mongoid seems to have moved the functionality from Mongoid::Association::Referenced::Eager::Base into Mongoid::Association::Eager. Changing the prepend to work on that module seems to make everything work as expected.

Additionally, I updated the Gemfile.lock to get the tests running. I am getting one test failure, on Mongoid::Includes::Criteria#includes multiple inclusions through polymorphic associations :with inclusions should not be overriden (expected: 4 times with any arguments, received: 3 times with any arguments). However, this also fails without any changes related to mongoid 9, so I don't think it's related to any changes I made. I also needed to add a Time.zone specification to the spec_helper, which is now required by mongoid.

[1st8]

The test failure is also present with Mongoid 7 and 8.1. Just to confirm that it's not related to your changes.

[jclusso]

@ElMassimo any plans to review / merge this?

[cperezabo]

I don't understand the silence, he is not dead because he has pushed to another repo few hours ago. Tests are passing, it just needs a click to merge and publish the gem update (if not automatically done) 🤷🏻‍♂️

[jclusso]

I don't understand the silence, he is not dead because he has pushed to another repo few hours ago. Test are passing, it just needs a click to merge and publish the gem update (if not automatically done) 🤷🏻‍♂️

@cperezabo only guess I have is he has notifications turned off for this repo or something.

[remz99]

@ElMassimo any plans merge this?

[jclusso]

@ElMassimo checking in to see if this might get merged soon?

[ElMassimo]

I haven't used MongoDB or Mongoid for the past 5 years, so I no longer have a way to thoroughly test these changes.

Happy to transfer the library to @danarnold if interested, or to github/mongoid.

[danarnold]

@ElMassimo Sure, can you transfer ownership to the org https://github.com/cacheventures (which I'm a member of)?

[stanley90]

Hi, I found the following problem which should be fixed in this branch. Also, would like to vote for the gem ownership transfer and release 🤞

[jclusso]

@ElMassimo if you want to transfer it to @danarnold, myself, or directly to my company @cacheventures, the option is still there. We're using this gem and need to continue maintaining it anyway.

[ElMassimo]

@jclusso I've requested transferring this repo to your account, I didn't have permission to transfer it to @cacheventures, and @danarnold already has a fork of this repo so it wouldn't let me transfer it to his account.

I'll coordinate the transfer of the Ruby gem with you over email.

[jclusso]

@ElMassimo thanks, I got it!