beluga icon indicating copy to clipboard operation
beluga copied to clipboard

Add 1D particle filter tutorial code

Open Alondruck opened this issue 1 year ago • 2 comments

Proposed changes

Related to #305, split from #340.

Type of change

  • [ ] 🐛 Bugfix (change which fixes an issue)
  • [x] 🚀 Feature (change which adds functionality)
  • [ ] 📚 Documentation (change which fixes or extends documentation)

Checklist

  • [x] Lint and unit tests (if any) pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added necessary documentation (if appropriate)
  • [x] All commits have been signed for DCO

Alondruck avatar May 15 '24 13:05 Alondruck

@hidmic @nahueespinosa I want to ask you for advice. I intend to change the name of the folder to "beluga_tutorials" (it will serve as a meta-package) and relocate all this code to a new package, perhaps named "beluga_basic_mcl_demo" or "beluga_mcl_demo." Consequently, I plan to utilize this meta-package for future tutorials, such as "beluga_nav2_demo." Does that sound good to you?

Alondruck avatar May 16 '24 19:05 Alondruck

I don't dislike the idea, but it sounds like a lot of scaffolding for a simple tutorial. If we are going in that direction, I'd probably revamp beluga-demos for that purpose.

hidmic avatar May 16 '24 20:05 hidmic

@hidmic Should we wait for you to take a look?

@nahueespinosa No need to, I trust your judgement.

meta: If we add this as a package, will it be released?

We can choose not to. I'm inclined to not release example or tutorial packages, but I can be convinced otherwise.

hidmic avatar May 21 '24 12:05 hidmic

@Alondruck I would update the branch as soon as https://github.com/Ekumen-OS/beluga/pull/379 lands, to make sure we are in the clear across all supported distributions.

hidmic avatar May 21 '24 12:05 hidmic

FYI https://github.com/Ekumen-OS/beluga/pull/379 landed.

hidmic avatar May 21 '24 14:05 hidmic

@hidmic I think I need your approve to merge this PR

Alondruck avatar May 22 '24 13:05 Alondruck