Ekleog-NEAR

Results 40 comments of Ekleog-NEAR

I’m seeing that this is suggesting `keccak256(...)[12,32]` as a way to generate the hashes. Why is there these `[12,32]` magic numbers? Is it possible to document the rationale behind this...

This should be fixed by https://github.com/near/nearcore/pull/10818 :)

Just to manage expectations correctly: since 3 weeks ago we have been working on congestion on the protocol level. As such, work on reviewing this has currently been deprioritized to...

@CensoredUsername Hey! Just coming to check when you think you’d have a chance to release? (as you mentioned two weeks a month ago I’m just wondering whether maybe you forgot...

(Oh and also just the `reserve_ops` introduced in this PR if you’re on the same line as me about the fact that it’d make sense to have it alongside the...

No problem, and thank you for all you do on dynasm-rs anyway! Please let me know if there’s anything I can do to help out :)

That sounds great, fewer allocations is always better! Though since reading http://troubles.md/posts/improving-smallvec/ I’ve been a bit doubtful about SmallVec, and have tended to just go with using Vec with custom...

Sounds great to me! I’ll be happy to test with our wasmer as soon as you push the commit to dev; just let me know when you do so :)...

Sounds great to me! I’m now having a 21% performance gain compared to the last release (16.4 -> 12.9), or a 31% gain (16.4 -> 11.3) with the additional hack...

Actually nevermind what I said about the addition of `reserve_ops`: with [this change](https://github.com/near/wasmer/pull/146/commits/854eb60f19fd6aa80933f1ea9dfa10230dec4346) I’ve checked and `.drain()` does not seem to reduce capacity of the `Vec`, so the backing allocation...