Device icon indicating copy to clipboard operation
Device copied to clipboard

Swift 2.3 compatibility?

Open carmelogallo opened this issue 9 years ago • 7 comments

Hey guys, could be possible to have the compatibility with Swift 2.3?

carmelogallo avatar Sep 26 '16 15:09 carmelogallo

I'm going to submit a PR for this over the weekend. There's no reason we can't maintain a swift 2.3 branch and update for the iPhone 7 devices as well.

mitchellporter avatar Oct 27 '16 08:10 mitchellporter

The iPhone 7 is handled. I haven't the time to make a swift 2.3 compliant branch. So if you want I can create a specific branch and you can send a PR on it.

Ekhoo avatar Oct 27 '16 15:10 Ekhoo

Sure! I've already done it so I just need to do the PR.

carmelogallo avatar Oct 27 '16 19:10 carmelogallo

Here is the branch => https://github.com/Ekhoo/Device/tree/swift_2_3 :)

Ekhoo avatar Oct 28 '16 07:10 Ekhoo

But it's still Swift 3.0 code at this branch

saltwat5r avatar Oct 28 '16 08:10 saltwat5r

I've already created PR #36

saltwat5r avatar Oct 28 '16 08:10 saltwat5r

Merged 👍

Ekhoo avatar Oct 28 '16 12:10 Ekhoo