REE.PAK.Tool icon indicating copy to clipboard operation
REE.PAK.Tool copied to clipboard
verified publisher icon Ekey

Bug? Useless if condition

Open eigeen opened this issue 1 year ago • 0 comments

Position: https://github.com/Ekey/REE.PAK.Tool/blob/30b02f3f3fe4ef598d2152122f48dc947e069f01/REE.Unpacker/REE.Unpacker/FileSystem/Package/PakUnpack.cs#L82

m_Header.bMajorVersion == 2 && m_Header.bMajorVersion == 4 always equal to false.

In addition, if not for insurance purposes, the else if can be merged with else, because m_Header.bMinorVersion was previously determined that can only be 0 or 1.

eigeen avatar Aug 06 '24 14:08 eigeen