mpv-scripts icon indicating copy to clipboard operation
mpv-scripts copied to clipboard

SimpleHistory crashes with Ace Stream

Open Lc4B opened this issue 1 year ago • 9 comments

SimpleHistory crashes if I use an acestream:// link and also if I add it to the blacklist

[SimpleHistory] Lua error: D:/.../SimpleHistory.lua:1974: attempt to index a nil value

Lc4B avatar Apr 27 '24 12:04 Lc4B

I am getting it for every video I play after I upgraded mpv

thequantumcog avatar Apr 28 '24 16:04 thequantumcog

Pull request #142 Fixes the problem for me

thequantumcog avatar Apr 28 '24 16:04 thequantumcog

Pull request #142 Fixes the problem for me

for me this also doesn't solve the problem, it always gives me that error on that string with ace stream link

Lc4B avatar Apr 29 '24 10:04 Lc4B

Is there any acestream sample I can test it on? Never used this protocol before

Eisa01 avatar Apr 29 '24 10:04 Eisa01

you can find some links on AceStreamID, but you should download the engine and have the mpv script to try them. the links are like this acestream://0000000000000000000000000000000000000000 and honestly I would be fine even if they are not supported or put them in the blacklist, as long as SimpleHistory doesn't crash

Lc4B avatar Apr 29 '24 11:04 Lc4B

The crash could be related to different reason based on the log. It seems that your log file has an issue.

Try the latest script from scratch: Delete or rename the log file if you want to keep it Path for Windows OS: %APPDATA%\mpv\mpvHistory.log, Path for Linux OS and MAC OS: ~.config\mpv\mpvHistory.log

Re-download the latest script and config file (not from releases page but from the repository directly)

Let me know how it goes.

Eisa01 avatar Apr 29 '24 11:04 Eisa01

ok, I already had everything updated but by doing the tests cleanly you can see that the problem comes from the .conf file, as soon as I set anything in history_blacklist, in that case only if I open acestream links the script crashes (not with files or youtube links for example). I'm currently testing it without log file, with the base file and just changing the conf like this: history_blacklist=[".gif"] and it crashes, any suggestions?

Lc4B avatar Apr 29 '24 11:04 Lc4B

When blacklist is not touched, the script crashes or it works fine with acestream?

Eisa01 avatar Apr 29 '24 11:04 Eisa01

When blacklist is not touched, the script crashes or it works fine with acestream?

works fine

Lc4B avatar Apr 29 '24 11:04 Lc4B