purple-discord icon indicating copy to clipboard operation
purple-discord copied to clipboard

Support file attachments (uploads)

Open alexolog opened this issue 7 years ago • 20 comments

As the title says. The current plugin does not support attaching files.

alexolog avatar Dec 27 '17 00:12 alexolog

Any reason you would actually want this, as opposed to uploading it somewhere else and linking (possibly better for privacy as well, depending how DiscordBot behaves)?

alyssarosenzweig avatar Dec 27 '17 00:12 alyssarosenzweig

One can't really denny that just choosing the file and uploading it in-chat is more practical, for people who doesn't have some shell script to upload from the terminal or file browser.

DuendeInexistente avatar Dec 27 '17 00:12 DuendeInexistente

Sure, I can: a Pidgin plugin could intercept files and instead upload to a selected host, substituting in a link at will.


Hey, Ferb, I knew what we're going to do today!

alyssarosenzweig avatar Dec 27 '17 01:12 alyssarosenzweig

It's a question of convenience.

I can drag a file into the Discord client (or select it as an attachment) and it will upload it to the Discord servers and post a link. It works pretty well for channels, if the file size is below the limit, and for private conversations, if the files are not treated as actually private.

I guess the most flexible solution would be to support it with an option to specify a different upload host to upload to, as @bobbybee mentioned above.

And yes, it can be done manually, but it is less convenient.

alexolog avatar Dec 27 '17 06:12 alexolog

I guess the most flexible solution would be to support it with an option to specify a different upload host to upload to, as @bobbybee mentioned above.

More specifically, that this should be handled in Pidgin (or whatever people use) rather than in this prpl. I'm not even sure the prpl could implement this in a convenient generic way...

alyssarosenzweig avatar Dec 27 '17 07:12 alyssarosenzweig

What about a non-generic way?

alexolog avatar Dec 27 '17 07:12 alexolog

I haven't played with Pidgin/libpurple stuff in a little while; you'd have to ask Eion about that.

alyssarosenzweig avatar Dec 27 '17 07:12 alyssarosenzweig

Maybe you could execute a script and redirect its output to the message box, having a default host be a simple one like catbox.moe which supports curl upload.

DuendeInexistente avatar Dec 27 '17 17:12 DuendeInexistente

Oh and, maybe this'd be better as a standalone plugin, I don't see why have it only work on Discord.

DuendeInexistente avatar Dec 27 '17 17:12 DuendeInexistente

Oh and, maybe this'd be better as a standalone plugin, I don't see why have it only work on Discord.

^^ Exactly. I'm not opposed at all to the idea -- I'd just like it to work on XMPP too. No changes required on our end! :)

alyssarosenzweig avatar Dec 27 '17 18:12 alyssarosenzweig

Well surely its libpurple part. For example telegram-purple implements file sending thata available from pidgin. So not adding file sending support amd saying "do it yourself we dont care about fixing this bug" its not nice caus it is a bug and missing functionality.

Michal-Szczepaniak avatar Mar 08 '18 02:03 Michal-Szczepaniak

I'm keen to see 'native' Discord file transfers too, so some of us do care about adding this feature (not "fixing this bug") :)

It'll just happen faster if someone else feels like giving it a try to add support for it.

EionRobb avatar Mar 08 '18 03:03 EionRobb

@EionRobb thats good :) I would help if i could

Michal-Szczepaniak avatar Mar 08 '18 16:03 Michal-Szczepaniak

I agree any kind of general upload-paste-link feature should be a plugin which works with all protocols - file transfers aren't supported by a lot of the plugins as it is.

tomdwaggy avatar Mar 12 '18 07:03 tomdwaggy

Can this please be looked at? Thank you!

alexolog avatar Dec 02 '18 18:12 alexolog

Images uploaded to any host may be taken down without any notice (remember the photobucket catastrophe?). Theoretically, images uploaded to Discord should stay up for as long as Discord is up. Discord might also one day go down without any notice, but at least everyone should start moving to a different protocol instead. Also, as far as I know, Pidgin doesn't have any link preview plugins that will embed images.

Slider-Whistle avatar Nov 08 '19 06:11 Slider-Whistle

Also, as far as I know, Pidgin doesn't have any link preview plugins that will embed images.

Kiiiind of, there's an ancient plugin that would embed videos and allegedly images. But I don't remember it working anymore and the outdated dependencies make it hard to compile and, frankly, are excesive. Why do I need webkit's huge dev packages when pidgin can embed simple media on its own via html tags?

DuendeInexistente avatar Nov 08 '19 13:11 DuendeInexistente

Also, as far as I know, Pidgin doesn't have any link preview plugins that will embed images.

Not sure what it is, but there's something currently in use to allow for custom emojis to show up appropriately.

Jaegrqualm avatar Nov 08 '19 22:11 Jaegrqualm

Pidgin doesn't have any link preview plugins that will embed images.

Google Hangouts plugin has. I don't use the plugin now (and don't know how exactly it works) but I could see preview images that was sent to me and also I could easily drop an image to chat window and send it to someone.

T1mL3arn avatar Jan 30 '20 02:01 T1mL3arn

In the official Discord client, I use the feature of uploading images from the clipboard a lot (just crl+v on the text input). It would be wonderful to have it working on this plugin.

MangaD avatar Sep 01 '20 19:09 MangaD