StrideCommunity.ImGuiDebug icon indicating copy to clipboard operation
StrideCommunity.ImGuiDebug copied to clipboard

Update imgui

Open Doprez opened this issue 1 year ago • 1 comments

Updated to latest ImGui.NET package.

This should also work with code first now... that is still super specific though so whatever. Worst case it will work as it did before.

Need to validate that the key maps were not broken.

Doprez avatar Aug 04 '24 18:08 Doprez

I may have found a better ImGui .NET implementation managed by the Hexa game engine. I already converted this library to that one and I think I will switch to that instead of this update if you're ok with that @Eideren

It also works out of the box with some useful addon libraries which is a huge bonus.

https://github.com/HexaEngine/Hexa.NET.ImGui/tree/master

Addons available for plug and play: https://www.nuget.org/packages/Hexa.NET.ImPlot https://www.nuget.org/packages/Hexa.NET.ImNodes https://www.nuget.org/packages/Hexa.NET.ImGuizmo

Doprez avatar Aug 05 '24 16:08 Doprez

I decided to go with the full overhaul using Hexa.ImGui.

This PR now includes fixes for window resizing and the ability to scale text through the ImGuiSystem and gives the users access through the BaseWindow class.

Doprez avatar Aug 11 '24 00:08 Doprez

@Eideren speaking of the Keys, did you want me to go ahead and just add all the available ones to that dictionary?

Doprez avatar Aug 11 '24 12:08 Doprez

Thanks a bunch, looks really good ! Can you quickly go over why you've decided to swap to Hexa's bindings ? I'm guessing that it could be because of a lack of support for the latest imgui features ... just want to get your thoughts.

It was the latest features that became the issue like you guessed. Also since Hexa maintains the nuget packages for ImNodes, ImPlot and ImGuizmo I did not have to worry about the ImGui version like I was facing with the ImGui.NET package seen here.

My only initial concern is that ImGui.NET is maintained by a community whereas Hexa seems to only be one or two so there is some risk there but they did publish the repo that generates the bindings which made me feel more comfortable.

Doprez avatar Aug 11 '24 12:08 Doprez

@Doprez afaik those keys are only there for common UI operation shortcuts, let's leave it for now and investigate again if something doesn't work as expected.

Thanks again !

Eideren avatar Aug 11 '24 17:08 Eideren