HeishaMon icon indicating copy to clipboard operation
HeishaMon copied to clipboard

Just a little typo for answer of "SetDHWHeatDelta"

Open Bogeyof opened this issue 2 years ago • 3 comments

If I set "SetDHWHeatDelta" the answer is "set floor heat delta to.."

Code

unsigned int set_dhw_heat_delta(char *msg, unsigned char *cmd, char *log_msg) {
  unsigned int len = 0;
  String set_temperature_string(msg);

  byte request_temp = set_temperature_string.toInt() + 128;

  {
    char tmp[256] = { 0 };
    snprintf_P(tmp, 255, PSTR("set floor heat delta to %d"), request_temp - 128 );
    memcpy(log_msg, tmp, sizeof(tmp));
  }

  {
    memcpy_P(cmd, panasonicSendQuery, sizeof(panasonicSendQuery));
    cmd[99] = request_temp;
  }

  return sizeof(panasonicSendQuery);
}

Also the description in MQTT-Topics.md is wrong. This value must be set to "-12" - "-2". (For J-Model?).

MQTT-Topics.md SET20 | SetDHWHeatDelta | Set DHW heating delta in Kelvin | 1-15

Bogeyof avatar Jul 11 '22 07:07 Bogeyof

Yes , in H it is the same range : from -12 to -2 deg....

MiG-41 avatar Jul 11 '22 20:07 MiG-41

Answer-Text is corrected in v3.0, may be also in v2.2. Both are a problem for me, cause JSON-Output is different and I think it´s a bit messed up...

Bogeyof avatar Jul 12 '22 15:07 Bogeyof

As noticed also in https://github.com/Egyras/HeishaMon/issues/257 I am fixing the json output now

IgorYbema avatar Jul 12 '22 16:07 IgorYbema