Disasmo icon indicating copy to clipboard operation
Disasmo copied to clipboard

VSIX ships a lot of unrelated files, including Roslyn

Open Therzok opened this issue 4 years ago • 4 comments

It should just reference dlls and allow the roslyn host to load them. Right now, the extension (along with some others) cause my VS to not show quick info. :D

Therzok avatar Feb 28 '21 00:02 Therzok

@Therzok ah yeah, something definitely went wrong here 🙂 Initially the addin was based on the LightBulb sample from https://github.com/microsoft/VSSDK-Extensibility-Samples/tree/master/LightBulb (it's pretty out of date)

trying to figure out how to optimize it.

EgorBo avatar Feb 28 '21 13:02 EgorBo

hm.. looks like most of it comes with "Microsoft.CodeAnalysis.EditorFeatures.Text" nuget package which is only needed for GetRelatedDocuments() API

EgorBo avatar Feb 28 '21 14:02 EgorBo

You can most likely ship the vsix without bundling Roslyn, but by having a dependyencu on the .net sdk extension

Therzok avatar Feb 28 '21 19:02 Therzok

The assemblies exist in the appdomain, and the host will redirect you to the version it uses. Basically, all the imported packagereference that already exist in VS have to not be locally copied.

Therzok avatar Feb 28 '21 19:02 Therzok