Regarding removal of custom command

[kennethho]

Dear author,

Was it not safe for naive users or was it your implementation not safe, that you feel the feature "custom command" had to be removed?

If it was the former, I suppose adding a warning message should suffice.

For power users, we often need access to less popular features, for example, I had two custom commands:

1. Toggles between 2 selected input methods (from 4 installed IME)
2. Import my ssh key to a custom utility after fingerprint scan

These are not something I would ask you in feature requests, but very useful and convenient for power users who knows what they are doing.

Please consider restore the feature.

Otherwise, consider this issue as feature request to my use case. (just kidding) :-)

Regards,

• kenneth

[EggUncle]

In fact, my implementation not safe , even dangerous, it can make any command run in systemuiapplication and other app also can change the command , system process has heigher Authority,so i must be careful.. if you want to use this function ,it easy. You can download my source code and find https://github.com/EggUncle/XposedNavigationBar/blob/master/app/src/main/java/com/egguncle/xposednavigationbar/hook/btnFunc/BtnStartCommand.java ,delete the Annotations on line 37~42,then build a apk for yourself. I need learn more about it,and i need more time.

my english is poor,and I saw your info,if you come from Taiwan ,maybe you can read Chinese:

大兄弟我看你git好像是台湾的，我英文比较差劲，就还是用中文再说一下，这个功能的实现问题很大，有非常大的安全隐患。本身的command设置是通过广播发送到hook到systemui里面的广播接收器做的，而这个广播不光这个模块app可以发，所有app都可以发送这样的广播到我hook的systemui里面的那个广播接收器的位置，就可能造成其他危险应用给它发一些不安全的指令，然后再点击扩展按钮导致危险指令执行，我考虑再三还是把它先去掉了。 如果你想用这个自定义命令行的功能的话可以参照我上面说的，下载源码然后去除掉那个文件里面的一些注释，自己编译一个这个模块的app在安装到手机上。

thanks for your suggession : )