website icon indicating copy to clipboard operation
website copied to clipboard

Upgrade Shiki

Open lishaduck opened this issue 1 year ago • 4 comments

I've been looking into twoslash, and was curious how y'all had set it up. As I was looking, I noticed that y'all are still using Shikiji, which has been merged back into Shiki. I'd be willing to try to upgrade it if that's something y'all are interested in.

remark-shiki-twoslash is deprecated as well (which is how I noticed it).

P.S. This is blank issue because that was an option, and the others seemed like they were for the project, not the website. I'm not ignoring them. If it shouldn't be an option (sometimes people get annoyed at "blank" issues), you can disable the link in .github/ISSUE_TEMPLATE/config.yml for the future.

lishaduck avatar Jun 12 '24 18:06 lishaduck

@lishaduck - sorry for the delay. If you're willing to give it a go, I'd be willing to review your updates! Thanks!

IMax153 avatar Jul 10 '24 19:07 IMax153

Ok, so I took a much closer look, and apparently I signed up to upgrade quite a few dependencies. This is going to be fun![^1]

[^1]: Not sarcasm. Mostly.

lishaduck avatar Jul 10 '24 21:07 lishaduck

@IMax153, #770 is ready for review!

lishaduck avatar Jul 11 '24 19:07 lishaduck

Out of scope for the current PR, but I should also investigate https://twoslash.netlify.app/packages/eslint and see if it'd help with the docs for the ESLint plugin.

lishaduck avatar Aug 18 '24 23:08 lishaduck

@lishaduck - the rebuilt version of the site incorporates a custom Shiki Twoslash plugin that works with Expressive Code.

Feel free to take a peek: https://github.com/Effect-TS/website/blob/main/content/src/plugins/twoslash/plugin.ts

IMax153 avatar Oct 29 '24 19:10 IMax153

The new site looks great @IMax153. I imagine Astro's a lot faster too.

lishaduck avatar Oct 29 '24 23:10 lishaduck