effect icon indicating copy to clipboard operation
effect copied to clipboard

Fix/catchtag errors #5075

Open jfet97 opened this issue 6 months ago • 2 comments

Description

This is just a draft, it helps me to highlight the problem I found. That ...args trick is clever when it comes to step over the "A rest parameter must be last in a parameter list." error, but it seems to not play well with the kind of contextual parameters inference Effect.fnUntraced needs. OTOH the solution outlined in my commit requires manually passing an array of tags so the DX it's a little bit worse (and this should be ported to every overload of catchTag).

Related

Related Issue #5075

jfet97 avatar Jun 24 '25 16:06 jfet97

⚠️ No Changeset found

Latest commit: 168ae44a92f10622a79645de237aa9ccac9a4be1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 24 '25 16:06 changeset-bot[bot]

The issue is actually with the overload that assists autocompletion, if you remove it the ...args inference will work.

tim-smart avatar Jun 24 '25 21:06 tim-smart

The issue is actually with the overload that assists autocompletion, if you remove it the ...args inference will work.

I wasn't considering the possibility to remove those overloads you added at all ahah

jfet97 avatar Jun 25 '25 05:06 jfet97