effect icon indicating copy to clipboard operation
effect copied to clipboard

Make the generic type order consistent in the `Left`, `Right`, and `Either`

Open venusvavadiya opened this issue 1 year ago • 3 comments

Type

  • [x] Refactor
  • [ ] Feature
  • [ ] Bug Fix
  • [ ] Optimization
  • [ ] Documentation Update

Description

This PR makes the generic type order consistent between Left, Right, and Either. It updates Left<L, R> and Right<L, R> to Left<R, L> and Right<R, L>, respectively.

venusvavadiya avatar Sep 21 '24 01:09 venusvavadiya

🦋 Changeset detected

Latest commit: 13e8e4913cc8329d0cdd049ca0ced8dd9dec9cda

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
effect Major
@effect/cli Major
@effect/cluster-browser Major
@effect/cluster-node Major
@effect/cluster-workflow Major
@effect/cluster Major
@effect/experimental Major
@effect/opentelemetry Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc-http Major
@effect/rpc Major
@effect/sql-clickhouse Major
@effect/sql-d1 Major
@effect/sql-drizzle Major
@effect/sql-kysely Major
@effect/sql-libsql Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-do Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/typeclass Major
@effect/vitest Major
@effect/ai Major
@effect/ai-openai Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 21 '24 01:09 changeset-bot[bot]

Looks good but it's a breaking change so it would be for the next major

mikearnaldi avatar Sep 21 '24 20:09 mikearnaldi

Looks good but it's a breaking change so it would be for the next major

Thanks @mikearnaldi, I will add the necessary changeset.

venusvavadiya avatar Sep 22 '24 02:09 venusvavadiya

Hello @mikearnaldi, I have added the changesets and also resolved the conflicts. I hope this is good to merge! Let me know if I missed anything.

venusvavadiya avatar Feb 09 '25 06:02 venusvavadiya