effect icon indicating copy to clipboard operation
effect copied to clipboard

For `Data.TaggedEnum` added capitalized constructor naming convention.

Open KhraksMamtsov opened this issue 1 year ago • 3 comments

https://discord.com/channels/795981131316985866/920065989557747723/1242059983999467520 For Data.TaggedEnum added capitalized constructor naming convention. Helper functions $is and $match have been renamed to is and match. image

Type

  • [ ] Refactor
  • [x] Feature
  • [ ] Bug Fix
  • [ ] Optimization
  • [ ] Documentation Update

Description

Related

  • Related Issue #
  • Closes #

KhraksMamtsov avatar May 20 '24 13:05 KhraksMamtsov

🦋 Changeset detected

Latest commit: b7b76472bf2f17c8ef903fa951a85615fa7725ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
effect Major
@effect/cli Major
@effect/cluster-browser Major
@effect/cluster-node Major
@effect/cluster-workflow Major
@effect/cluster Major
@effect/experimental Major
@effect/opentelemetry Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc-http Major
@effect/rpc Major
@effect/schema Major
@effect/sql-d1 Major
@effect/sql-drizzle Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/typeclass Major
@effect/vitest Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 20 '24 13:05 changeset-bot[bot]

Maybe instead of enforcing capitalisation, we just reserve the is and match keywords?

If a user wants lower case tags, then I don't think we should prevent that.

tim-smart avatar May 24 '24 23:05 tim-smart

with this restriction, we reserve space for helpers that may appear in the future. otherwise, it will be a breaking change every time.

KhraksMamtsov avatar May 25 '24 08:05 KhraksMamtsov