Don't log an empty message
Type
- [ ] Refactor
- [x] Feature
- [ ] Bug Fix
- [ ] Optimization
- [ ] Documentation Update
Description
Related
- Related Issue #
- Closes #
🦋 Changeset detected
Latest commit: 80e2af18c78ae88cfcd6ebf5074bbe919f30f598
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 9 packages
| Name | Type |
|---|---|
| @effect/platform | Patch |
| @effect/cli | Patch |
| @effect/experimental | Patch |
| @effect/platform-browser | Patch |
| @effect/platform-bun | Patch |
| @effect/platform-node-shared | Patch |
| @effect/platform-node | Patch |
| @effect/rpc-http | Patch |
| @effect/rpc | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
The empty message was intentional, as all the information is in the annotations. Was it breaking something for you?
It's not breaking anything, it was just a little harder when eyeballing a stream of log messages. (Though this was the only case where the message was empty, so easier once I worked that out. 🙃)
The empty message was intentional, as all the information is in the annotations. Was it breaking something for you?
Any reason why a log message would be bad?
Not bad, but my only nit pick is that it makes the stream of logs quite repetitive, as the message adds no value.
Are we logging purely annotations?
Yes currently. I'll merge this, as I think adding a message will be useful for cloud dashboards when filtering.