김병주
김병주
> @EdwardArchive, one thing: could you add some SQL tests to verify that your changes work? Hi @alvin-celerdata, do you have any ideas for creating test SQL on this PR?...
> > > @EdwardArchive, one thing: could you add some SQL tests to verify that your changes work? > > > Hi @alvin-celerdata, do you have any ideas for creating...
@alvin-celerdata Hi, is there any comment on my code? thanks Done!
@alvin-celerdata Hi, this PR(https://github.com/StarRocks/starrocks/pull/66206) depends on the Named Arguments feature I'm working on in another branch. I'd like to set that branch as the base for this PR (stacked PRs),...
I just working on it find some edge case
@k-anshul Hi, Can you help review this change so we can move it forward?
Thank you for the Hard works! I'll fixed it
Hi @k-anshul, Thank you so much for taking the time to review my code — I really appreciate it, especially since it was likely during the weekend or early morning...
> Hey @EdwardArchive > > Thanks for your work here. I added some more comments. Mostly should be minor. Please also take a look at the failing checks. Hey @k-anshul...
Hey @k-anshul, I’ve made a number of the changes you suggested. Please review when you get a chance.