rsmtool icon indicating copy to clipboard operation
rsmtool copied to clipboard

Deprecate _modify_eval_columns_to_ensure_version_compatibilty in RSMCompare

Open aloukina opened this issue 5 years ago • 2 comments

The Comparer class in comparer.py currently contains a class _modify_eval_columns_to_ensure_version_compatibilty to allow running RSMCompare on outputs from RSMTool < 7.0. I think it's time to deprecate this.

aloukina avatar Nov 12 '20 03:11 aloukina

It seems that in later versions of RSMTool, we want to remove support for SMD, in subgroup calculations, and only support DSM. However, SMD is used for all lists of column names (both raw and scaled). See lines 29 and 36 for example, and is only changed to DSM inside _modify_eval_columns_to_ensure_version_compatibilty(), a function we want to deprecate.

Essentially, this issue is larger than initially assumed. Will be dealt with in a later release.

Frost45 avatar May 27 '21 19:05 Frost45

Also, no warnings are filtered in _modify_eval_columns_to_ensure_version_compatibilty, but filter_warnings is passed as an argument to the function.

Frost45 avatar May 27 '21 19:05 Frost45