Edouard CHIN

Results 22 comments of Edouard CHIN

Thanks for opening the issue. I dug on this, and it's not going to be simple to put back the original behaviour. The behaviour changed because of https://github.com/rails/rails/commit/136fc65c9b8b66e1fb56f3a17f0d1fddff9b4bd0 which was...

Hello Benoit 👋 , thanks for opening the issue. Any chance you could point me to a public project using Circle CI (and if possible with a failing build). I'll...

I released v0.2.0 which adds support for Circle CI. https://github.com/Edouard-chin/ci_runner/releases/tag/v0.2.0 You can update the gem by running `gem update ci_runner`. Going to close this, but please reopen an issue if...

👋 I dug a bit on this issue, it's non trivial to fix since Minitest will init the plugin only only during the ruby `at_exit` hook https://github.com/seattlerb/minitest/blob/e6bc4485730403faff6966c1671cf5de72b2d233/lib/minitest.rb#L53 (way after the...

@catana-dev bump next week

Fixed by https://github.com/rails/rails/pull/44695

Thanks for the quick review. > Should we also remove the faulty test added 👍. I replace them with integration tests instead.

> https://guides.rubyonrails.org/active_record_validations.html#skipping-validations lists a bunch of methods [...] which in addition to skipping validations also skips callbacks [...] but should also be mentioned there. Isn't that page only related to...

I can't reproduce. Can you tweak this bug template to reproduce the problem? Bug template ```ruby # frozen_string_literal: true require "bundler/inline" gemfile(true) do source "https://rubygems.org" git_source(:github) { |repo| "https://github.com/#{repo}.git" }...

You aren't destroying any records in your bug report 🤔 , so it's normal the after_destroy callback doesn't get called.