Edirom-Online icon indicating copy to clipboard operation
Edirom-Online copied to clipboard

Fix: installation workflow readme also for Windows

Open daniel-jettka opened this issue 3 months ago • 6 comments

Description, Context and related Issue

  • added hints for commands on Windows machines
  • hint that alternative to git clone is downloading zip or tar

Refs #593

How Has This Been Tested?

tested on Windows

Types of changes

  • Documentation Update
  • Improvement

Overview

  • I have updated the inline documentation accordingly.
  • I have performed a self-review of my code, according to the style guide
  • I have read the CONTRIBUTING document.

daniel-jettka avatar Sep 22 '25 12:09 daniel-jettka

Couldn't test the change in line 119f., but the rest looks nice! Thank you :)

Was there a problem, or did you just have no time to test further?

daniel-jettka avatar Sep 24 '25 08:09 daniel-jettka

Couldn't test the change in line 119f., but the rest looks nice! Thank you :)

Was there a problem, or did you just have no time to test further?

I don't have a windows machine ;-) The other changes are exactly what I did, when I noticed the problem, so they must work.

riedde avatar Sep 24 '25 18:09 riedde

Couldn't test the change in line 119f., but the rest looks nice! Thank you :)

Was there a problem, or did you just have no time to test further?

I don't have a windows machine ;-) The other changes are exactly what I did, when I noticed the problem, so they must work.

Ah, I see :-) Thanks for noting

daniel-jettka avatar Sep 25 '25 07:09 daniel-jettka

I tested this out on my Windows 10 machine.

  1. Fastlane Installation
  • This works fine.
  1. Step-by-Step Installation:
  • This works fine, including Optional Step 3.
  • However, Optional Step 2 - "Specify the Edirom Online version (for developers)" - gives me an error message when I try to use a different fork:
=> CANCELED [builder 3/6] RUN wget --no-check-certificate --no-cookies http://archive.apache.org/dist/ant/bi  25.2s
failed to solve: executor failed running [/bin/sh -c echo "Cloning from repo $SOURCE" &&     git clone "$SOURCE" --branch "$BRANCH" --single-branch . &&     echo "Building Backend XAR..." &&     ant]: exit code: 128

mss2221 avatar Sep 25 '25 08:09 mss2221

This needs more testing, moving it to next milestone

daniel-jettka avatar Oct 01 '25 07:10 daniel-jettka

@roewenstrunk Does ZIM have machines for us to test on Windows? :-)

daniel-jettka avatar Nov 03 '25 10:11 daniel-jettka