Edirom-Online icon indicating copy to clipboard operation
Edirom-Online copied to clipboard

Feature: reintroduce iframe view

Open riedde opened this issue 3 years ago • 5 comments

While scanning the code I found some fragments of an iframe view. This PR is a contribution to reintroduce it.

riedde avatar Nov 27 '22 17:11 riedde

@riedde, what’s the status of this draft? @Edirom/edirom-online-developer is there a need for an iFrameView – showing external resources might be a useful feature.

bwbohl avatar Feb 05 '24 22:02 bwbohl

I'm not sure about my intention I had on this PR. Maybe to remodel a feature that has been lost at some day. Maybe I also tried to view the content of another eXist-App in an Edirom window (as the RWA did years ago).

riedde avatar Feb 07 '24 07:02 riedde

Might be usefull in some cases. Was it removed in the past?

DennisFriedl avatar Feb 07 '24 08:02 DennisFriedl

Maybe deactivated or lost somehow. But not fully deleted, fragments are still there. So I think it wasn't planned to cut it out.

riedde avatar Feb 07 '24 08:02 riedde

It should still work, i think. We still use it. For example here, when you click on „Textvergleich“ in the navigator: https://www.reger-werkausgabe.de/edition.html?workID=rwa_work_00036. It will open an object window containing an iFrame that is loading our text comparison tool.

Side note: Edirom-Online within RWA Online is provided within an iFrame. So: RWA Online -> iFrame Edirom-Online -> iFrame text comparison.

nikobeer avatar Feb 07 '24 10:02 nikobeer

@roewenstrunk Do we have progress on this? If yes, could you push the changes we have done at our meeting?

riedde avatar Nov 13 '24 07:11 riedde