Edirom-Online icon indicating copy to clipboard operation
Edirom-Online copied to clipboard

Check how measure numbers in annot tool tips are retrieved, there seems to be something wrong…

Open nikobeer opened this issue 3 years ago • 6 comments

Bildschirmfoto 2022-09-23 um 18 04 14

nikobeer avatar Sep 23 '22 16:09 nikobeer

Attribute "n", "label" or what…?

nikobeer avatar Sep 23 '22 16:09 nikobeer

could you please describe what you were expecting in the above example, both visually and in terms of encoding, and maybe provide encoding examples?

bwbohl avatar Oct 05 '22 13:10 bwbohl

As you self-assigned: will you fix this by yourself or do you need some help?

bwbohl avatar Oct 05 '22 13:10 bwbohl

Yes, I will fix it – at the end of October/beginning November. There is probably a special xquery for these tooltips that is not aware of some "logic modifications" we made to the full Annotation View xquery in the past.

nikobeer avatar Oct 05 '22 13:10 nikobeer

Beginning at getAnnotations.xql…

nikobeer avatar Nov 23 '22 11:11 nikobeer

The problem is not supported @label in line https://github.com/Edirom/Edirom-Online/blob/ea4c7c3479b8cc62569a8cb5c247c5447456fb89/add/data/xql/getAnnotation.xql#L208

roewenstrunk avatar Dec 14 '22 13:12 roewenstrunk

@nikobeer what is the status of this issue?

krHERO avatar May 30 '24 07:05 krHERO

This problem is not solved yet.

nikobeer avatar Jun 04 '24 09:06 nikobeer

Fixed. @bwbohl please close when pulled…

nikobeer avatar Jun 04 '24 10:06 nikobeer

am I right to assume that the to above commits in the MRI Edirom Online are the fix for this issue?

bwbohl avatar Jun 04 '24 10:06 bwbohl

The first (fe4ed58) is in the MRI's repo. It is only valid for the RWA Edirom as getAnnotation.xql there looks completely different from the original Edirom file. The second (a55a0f5) is the actual fix for Edirom (same code change). See https://github.com/Edirom/Edirom-Online/pull/380.

nikobeer avatar Jun 04 '24 10:06 nikobeer

thx for clarifying, oversay the corresponding PR. I now linked the issue and the PR from the Development section in the righthand siedebar

bwbohl avatar Jun 04 '24 10:06 bwbohl