Edirom-Online icon indicating copy to clipboard operation
Edirom-Online copied to clipboard

SearchWindow: Use edition path for collection function

Open roewenstrunk opened this issue 4 years ago • 1 comments

https://github.com/Edirom/Edirom-Online/blob/develop/add/data/xql/search.xql at the moment queries the database root (/db) collection; thus it returns result from outside the current edition context

roewenstrunk avatar Dec 01 '21 13:12 roewenstrunk

Is there a canonical function for retrieving the edition context? Is this somehow related to #83 ?

peterstadler avatar Sep 13 '24 18:09 peterstadler

@roewenstrunk Kun je daar wat dieper op ingaan?

hizclick avatar Oct 24 '24 09:10 hizclick

@hizclick this is basically about the hard coded paths in

https://github.com/Edirom/Edirom-Online/blob/91abe6bf70d80b886a1cdb8240419b83d0396af5/add/data/xql/search.xql#L76-L85

Looking at these the collection that is being queried is '/db' – the whole database. This of course might make sense in some context (e.g., when an Edirom deployment only includes one edition of one work). But, e.g., if you have multiple editions installed the search will also return hits from those.

bwbohl avatar Nov 07 '24 09:11 bwbohl

@peterstadler

No there is not but there definitely should be! Such a function could be useful in many places in the Edirom Online.

bwbohl avatar Nov 07 '24 09:11 bwbohl