Update setup.py - matplotlib

[agsdot]

matplotlib needed in https://github.com/Edinburgh-Genome-Foundry/pdf_reports/blob/6908f49a16007f882f108580e18503f492bea9fd/pdf_reports/tools.py#L15 .

[veghp]

Thank you for spotting this, indeed it requires matplotlib for certain functions. It's a large dependency so I'm thinking whether to make it an optional install option (as in DNA Chisel for example)

[agsdot]

:+1:

[agsdot]

Any update on this @veghp , also I'm curious. How could I use tailwindcss 3 instead of semantic for this project?

[Zulko]

I am also voting for making matplotlib optional, the import is only used line 162:

if isinstance(fig, Axes):

This is really just a "comfort" check (the user could provide the ax.figure directly) and this could be replaced by the following which, although slightly less stringent, removes the need for matplotlib entirely

if fig.__class__.__name__ == "Axes":

[veghp]

Yes I vote on that option too. I can implement it this week.

@agsdot re your other question, I haven't used tailwindcss, but for semantic, the css is stored here: https://github.com/Edinburgh-Genome-Foundry/pdf_reports/tree/master/pdf_reports/css which is loaded here https://github.com/Edinburgh-Genome-Foundry/pdf_reports/blob/6908f49a16007f882f108580e18503f492bea9fd/pdf_reports/pdf_reports.py#L54 and used in this function: https://github.com/Edinburgh-Genome-Foundry/pdf_reports/blob/6908f49a16007f882f108580e18503f492bea9fd/pdf_reports/pdf_reports.py#L112

To use other styles, set use_default_styling=False and specify extra CSS filepath(s) with extra_stylesheets=()

extra_stylesheets List of paths to other ".css" files used to define new styles or overwrite default styles.

Would that solve the question?