DnaWeaver icon indicating copy to clipboard operation
DnaWeaver copied to clipboard

Published 20 hours ago • verified publisher icon Edinburgh-Genome-Foundry

Bug: Max length initialisation

Open andrewshvv opened this issue 3 years ago • 2 comments

I believe it should be sequence_length + 1 otherwise GoldenGatePartLibrary might be ignored if the whole sequence is from the library.

https://github.com/Edinburgh-Genome-Foundry/DnaWeaver/blob/6a26b08d9571fbaf91ac7058d45ed0706333e05d/dnaweaver/DnaSupplier/builtin_suppliers/DnaAssemblyStation/SequenceDecomposer.py#L124

Because here you make a comparison of this form: https://github.com/Edinburgh-Genome-Foundry/DnaWeaver/blob/6a26b08d9571fbaf91ac7058d45ed0706333e05d/dnaweaver/DnaSupplier/builtin_suppliers/DnaAssemblyStation/SequenceDecomposer.py#L173

andrewshvv avatar Apr 28 '21 05:04 andrewshvv

Thanks for reporting this. Can you confirm that the fix you are suggesting is solving your issue? If yes can you open a PR?

Zulko avatar Apr 28 '21 13:04 Zulko

Sorry, I thought I have answered.

Yeah, I can confirm it solved the issue, will try to make a PR soon.

andrewshvv avatar May 06 '21 18:05 andrewshvv