shifu icon indicating copy to clipboard operation
shifu copied to clipboard

TelemetryService should insert into database using device name instead of SKU

Open tomqin93 opened this issue 8 months ago • 0 comments

Is your feature request related to a problem? Please describe.

Currently when we enable telemetryService for a device with SQL, the name of the entry will be the SKU of the device in edgeDevice. This makes it harder to manage when we have to identical devices with the same SKU

Describe the solution you'd like

The solution would be to use device name for now. Since they are unique for a Kubernetes cluster. For now let's keep it within a single cluster. We can add in cluster id in the future

Describe alternatives you've considered

Using a slightly different SKU number for different devices

Additional context

Should be fixed here https://github.com/Edgenesis/shifu/blob/main/pkg/deviceshifu/deviceshifubase/pushtelemetry.go#L26

tomqin93 avatar Dec 07 '23 02:12 tomqin93