shifu icon indicating copy to clipboard operation
shifu copied to clipboard

convert DeviceShifuBase data structure from single EdgeDevice to a list type of EdgeDevice

Open kris21he opened this issue 1 year ago • 3 comments

Change EdgeDevice type from single type to array type, only support first item of config so not breaking current behavior.

Accept criteria:

  1. in examples/httpDeviceShifu/deployment/http-edgedevice.yaml, let's config as following
spec:
  -sku: "device1"
    connection: Ethernet
    address: 192.168.11.16:12345
    protocol: HTTP
  1. after this change, make shifu still working with following command
kubectl apply -f examples/httpDeviceShifu/deployment
  1. if there are multiple edgedevices in http_edgedevice.yaml file, always use the first one and ignore others

kris21he avatar Mar 14 '23 08:03 kris21he

Hey @kris21he, I would like to work on this!!

SuperAayush avatar Apr 20 '23 15:04 SuperAayush

Hi @SuperAayush , thank you so much! I will assign this issue to you. If you ever need anything, feel free to reach out to us, my e-mail address is [email protected]

tomqin93 avatar Apr 21 '23 00:04 tomqin93

@SuperAayush I am so glad that you picked this up, any questions free free to let us know. Looking forward to your ideas, thoughts, and PR for this. Thank you for your enthusiasm of contributing to the shifu community!

kris21he avatar Apr 23 '23 02:04 kris21he