edgetx icon indicating copy to clipboard operation
edgetx copied to clipboard

Change lcd.sizeText() name to lcd.getTextSize()

Open pfeerick opened this issue 4 years ago • 5 comments

Resolves #774 Needs corresponding update to luadocs

pfeerick avatar Oct 25 '21 11:10 pfeerick

https://github.com/EdgeTX/edgetx/issues/776#issuecomment-955114360

jfrickmann avatar Oct 30 '21 00:10 jfrickmann

So what's the verdict on #952 and #953? Please remember the PR names are slightly misleading... the old function call names are still available, but considered depreciated (i.e. it's the advance notice that it will most likely be removed in a future major version interval).

Tagging you as you're Lua devs ;) For those not aware, please also have a look at the LUA API Revamp project issues (link is in the right sidebar) and give your feedback to any of the issues raised. @jfrickmann @JimB40 @lshems @wimalopaan

pfeerick avatar Nov 28 '21 00:11 pfeerick

I think that we should drop it and keep the existing names.

jfrickmann avatar Nov 28 '21 00:11 jfrickmann

There was a good reason behind to use get.... set.... convention and to choose as much self-explanatory name as possible and it's code readability Otherwise we can name any new func 001, 002, 003. I can see OTX start was good then every-body was adding 'whatever' in General. And seems we continue this trend. In ETX we have 2 new filesys func. fstat & dir thrown into General.

JimB40 avatar Nov 28 '21 10:11 JimB40

Pushing this to 2.7 as this needs more engagement from Lua devs.

IMO the current API is a mess, is not intuitive in the name of of a lot of the functions, but I'm not a everyday user of it, so I'm not just going to push this without more engagement and feedback.

pfeerick avatar Dec 01 '21 03:12 pfeerick

I would like to drop this an favor of "the big LUA api update". We should and will clean up the API there, so this singulare change does not make much sense, currently. Does anyone have a differing opinion here?

gagarinlg avatar May 05 '23 14:05 gagarinlg

Indeed... this and #953 can go, and the underlying two issues being addressed incorporated into the discussion on the Lua API

pfeerick avatar May 07 '23 04:05 pfeerick