edgetx icon indicating copy to clipboard operation
edgetx copied to clipboard

EVT_VIRTUAL_NEXT / EVT_VIRTUAL_PREV on T12 wrong value

Open wimalopaan opened this issue 4 years ago • 5 comments

EVT_VIRTUAL_NEXT / EVT_VIRTUAL_PREV on T12 have the wrong values (98, 99) instead of (100, 101).

wimalopaan avatar Oct 15 '21 15:10 wimalopaan

Since you know the Lua side of things better than me... can you clarify a few things here:

  • if you have a name for the event... ie. EVT_VIRTUAL_NEXT, why are you looking at the ID?
  • it has the wrong value in reference to what? What makes 100,101 the right values?

As my understanding of the events atm is is that because different transmitters / families will expose different events, and the events are basically in a list, that for example... EVT_VIRTUAL_POTATO is not going to be equal to 100 on all radios, nor was it expected to be since it was given a name? Or can the name = index relationship be looked up in code?

pfeerick avatar Jan 17 '22 10:01 pfeerick

jumper t-lite has the same problem.

kasatka60 avatar Jan 17 '22 18:01 kasatka60

Yeah, I've always had this through that going up and down used the buttons the right way, but increment and decrement were back to front on the t-lite... meaning the buttons are probably mapped the wrong way around.

pfeerick avatar Jan 17 '22 23:01 pfeerick

How can I change the source code myself to fix it?

kasatka60 avatar Apr 12 '22 11:04 kasatka60

You would fork the repository, make a branch and commit your changes there. If you want your changes to be merged into main EdgeTX development, you create a pull request from your fork's branch against the main EdgeTX repository.

For building and testing your mods, see: https://github.com/EdgeTX/edgetx/wiki/Building-and-debugging-EdgeTX

rotorman avatar Apr 12 '22 12:04 rotorman