edgetx icon indicating copy to clipboard operation
edgetx copied to clipboard

Audio related feature requests

Open MrBlackmidi opened this issue 7 months ago • 15 comments

Is there an existing issue for this feature request?

  • [x] I have searched the existing issues

Is your feature request related to a problem?

Allow the user to choose what type of wave form the beep produces (sine, square, sawtooth, triangle and pulse (sort of like PWM but has a 25% duty cycle vs 50%)) and to set different pitch of tone depending on the action (scrolling vs pressing sys, mdl etc)

(applies to B/W only) Allow the beep sound to play while pressing sys, mdl etc

Describe the solution you'd like

A setting to change the waveform type the beep plays (mentioned in the top box) and allow users to set different pitch of tone depending on the action

Describe alternatives you've considered

There are not really (except modifying the code)

Additional context

https://github.com/user-attachments/assets/f33a454c-0e4e-4111-8524-182a30294b60 (Video edited via companion)

MrBlackmidi avatar May 14 '25 02:05 MrBlackmidi

Is it really difficult to find a script to normalize sound files, it even looks like there's one in this project? I don't know why it's there but maxvolume.cmd looks like it normalizes wav files. There is a wav volume control but correcting the sound files seems like a better thing to do.

pagrey avatar May 14 '25 20:05 pagrey

i would also like to add for to allow a pitch change when the jog wheel is pressed

MrBlackmidi avatar May 18 '25 00:05 MrBlackmidi

Exhibit A: allow the users to increase the gain (in db) for .wav files (for sound packs that aren't full volume)

As @pagrey said, this is trivial to find online, as well as some examples of how to do it are still present via old scripts in this project still (and also related more to sdcard content than firmware). For example, a quick google search brought up these two results on how to use Audacity (a freely downloadable audio file editor) to both normalise audio files, and how to do batch normalisation.

https://manual.audacityteam.org/man/normalize.html https://brianli.com/how-to-batch-normalize-audio-with-audacity/

Exhibit B: allow the user to choose what type of wave form the beep produces (sine, square, sawtooth, triangle and pulse)

Unless there is really a great need for this, would it not be better/simpler to simply create some wave files with those particular beep sounds/types? And use the play track SF?

i would also like to add for to allow a pitch change when the jog wheel is pressed

I'm not sure exactly what you are asking for here? pitch change of what? when? why?

pfeerick avatar May 18 '25 01:05 pfeerick

Unless there is really a great need for this, would it not be better/simpler to simply create some wave files with those particular beep sounds/types? And use the play track SF?

What I mean is that you are able to change the waveform type for scrolling, selecting things, etc

I'm not sure exactly what you are asking for here? pitch change of what? when? why?

What I mean is that when you are scrolling through the menu(s), it plays at a high pitch for example, when you select things (by pressing the jog wheel for example) it plays at a lower (or higher) pitch https://youtu.be/bKUNAplCQC0?si=vZi4bziVulfaDn_A&t=31 context

Also for the beep pitch, I would love for it to to have a range of + and -300hz instead of just +300hz

MrBlackmidi avatar May 18 '25 09:05 MrBlackmidi

what do you think?

MrBlackmidi avatar May 20 '25 05:05 MrBlackmidi

also would also love for an option to allow it to beep when the sys, pg left, pg right, rtn, tele and mdl

MrBlackmidi avatar May 22 '25 02:05 MrBlackmidi

This already exists. Change Radio Settings -> Radio Setup -> Sound -> Mode to "All" (default is NoKey IIRC).

On Thu, 22 May 2025, 12:08 pm MrBlackmidi, @.***> wrote:

MrBlackmidi left a comment (EdgeTX/edgetx#6257) https://github.com/EdgeTX/edgetx/issues/6257#issuecomment-2899695316

also would also love for an option to allow it to beep when the sys, pg left, pg right, rtn, tele and mdl

— Reply to this email directly, view it on GitHub https://github.com/EdgeTX/edgetx/issues/6257#issuecomment-2899695316, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ66KIA4J6YGAZVCE6X3KT27UWTHAVCNFSM6AAAAAB5CCMLIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOJZGY4TKMZRGY . You are receiving this because you commented.Message ID: @.***>

pfeerick avatar May 22 '25 05:05 pfeerick

It only works for scrolling and pressing on the jog wheel, not on the sys etc buttons (at least in companion, as I don't have a physical edgetx radio)

MrBlackmidi avatar May 22 '25 05:05 MrBlackmidi

It works on actual hardware.

On Thu, 22 May 2025, 3:47 pm MrBlackmidi, @.***> wrote:

MrBlackmidi left a comment (EdgeTX/edgetx#6257) https://github.com/EdgeTX/edgetx/issues/6257#issuecomment-2899991423

It only works for scrolling and pressing on the jog wheel, not on the sys etc buttons (at least in companion, as I don't have a physical edgetx radio)

— Reply to this email directly, view it on GitHub https://github.com/EdgeTX/edgetx/issues/6257#issuecomment-2899991423, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ66KPTCBG3AQJVDS36SX327VQHDAVCNFSM6AAAAAB5CCMLIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOJZHE4TCNBSGM . You are receiving this because you commented.Message ID: @.***>

pfeerick avatar May 22 '25 08:05 pfeerick

oh ok, I realise that I am talking in regards to the B/W screens rather than the colour screens

MrBlackmidi avatar May 22 '25 09:05 MrBlackmidi

do you have a say on this? sorry if i have been nagging you

MrBlackmidi avatar May 23 '25 05:05 MrBlackmidi

https://github.com/user-attachments/assets/f33a454c-0e4e-4111-8524-182a30294b60 (Video Edited) Demonstration for this feature request

MrBlackmidi avatar May 27 '25 01:05 MrBlackmidi

any devs?

MrBlackmidi avatar Jun 06 '25 09:06 MrBlackmidi

are any devs able to check this out? as this hasn't got any other response for a few weeks now

MrBlackmidi avatar Jun 09 '25 00:06 MrBlackmidi

EdgeTX development is a small team of volunteers giving up their own time to do this, and we are all very busy.

Someone may look at this if and when they have time; but constantly asking for it is not going to make it happen any faster, and will only serve to annoy everyone.

philmoz avatar Jun 09 '25 01:06 philmoz