edgetx icon indicating copy to clipboard operation
edgetx copied to clipboard

2.11.0 RC4 "Write Models and Settings to Radio" disabled in Companion

Open RC-SOAR opened this issue 8 months ago • 4 comments

Is there an existing issue for this problem?

  • [x] I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Companion

Current Behavior

Even after verifying a valid USB connection, "Write Models and Settings to Radio" is shown disabled (grayed out) in the Companion menu. Applies to the GX12 profile and some others.

Expected Behavior

The option should be enabled.

Steps To Reproduce

Open Companion 2.11.0 RC4. Create a model and attempt to write to radio.

Version

2.11.0-rc

Transmitter

RadioMaster GX12

Operating System (OS)

Windows

OS Version

10

Anything else?

No response

RC-SOAR avatar Apr 26 '25 10:04 RC-SOAR

This may just be new unexpected behaviour. Is the model status indicator indicating there is a issue with your model setup?

ie. here I have MODEL55 in error (there is one model with errors), and if I click the greyed out button in the toolbar after selecting the model with the name in red, I'll get told what the issue with the model is.

Image

Image

Once you've cleared any invalid model settings, the indicator will be green, and you'l be able to write to radio and simulate again.

pfeerick avatar Apr 26 '25 10:04 pfeerick

You're right of course ... the status indicator was red!

I didn't notice the status line, neither did I relate the red entry to the disabled state of the 'Write Models' menu item. Partly because a red indicator for rx # didn't prevent writing in 2.10. And partly because I simply unaware of the new behaviour.

Also, it's not clear how to display the errors.

A couple of suggestions:

  1. IMO the correct location for the 'display errors' button is next to the Models status indicator. See red, click the button next to it, voila!

  2. How about keeping the 'Write Models' menu item enabled, but display a message 'Errors in setup must be fixed before writing'? I think it would help to avoid confusion, as it's a fairly major change in behaviour. (A user of one of my templates was also confused by this.)

(BTW the 'display errors' button doesn't actually work at the moment - I suspect this is already due to be fixed?)

RC-SOAR avatar Apr 26 '25 12:04 RC-SOAR

BTW the 'display errors' button doesn't actually work at the moment - I suspect this is already due to be fixed

No, it does work... It only displays errors for the selected model, when relevant. i.e. you need to click on the model name with red name for it to work.

On Sat, 26 Apr 2025, 10:42 pm Mike Shellim, @.***> wrote:

RC-SOAR left a comment (EdgeTX/edgetx#6153) https://github.com/EdgeTX/edgetx/issues/6153#issuecomment-2832126355

You're right of course ... the status indicator was red!

I didn't notice it, neither did I relate it to the disabled state of the 'Write Models' menu item. Partly because a red indicator for rx # didn't prevent uploading in 2.10. And partly because I simply unaware of the new behaviour. I think the new behaviour needs to be more obvious, also it's not obvious how to display a list of errors.

A couple of suggestions:

IMO the correct location for the 'display errors' button is next to the Models status indicator. See red, click the button next to it, voila! 2.

How about keeping the 'Write Models' menu item enabled, but display a message 'Errors in setup must be fixed before writing'? I think it would help to avoid confusion, as it's a fairly major change in behaviour. (A user of one of my templates was also confused by this.)

(BTW the 'display errors' button doesn't actually work at the moment - I suspect this is already due to be fixed?)

— Reply to this email directly, view it on GitHub https://github.com/EdgeTX/edgetx/issues/6153#issuecomment-2832126355, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ66KKWCJB75WICTAFK4LD23N5KHAVCNFSM6AAAAAB35H7MQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMZSGEZDMMZVGU . You are receiving this because you commented.Message ID: @.***>

pfeerick avatar Apr 26 '25 19:04 pfeerick

My mistake - it's working as you describe (was looking at the radio settings icon).

The new way of trapping errors before upload makes a lot of sense, but I still think a few UI tweaks could improve the user experience.

RC-SOAR avatar Apr 27 '25 10:04 RC-SOAR