edgetx icon indicating copy to clipboard operation
edgetx copied to clipboard

chore: use single target to support nv14/el18/pl18/pl18ev/nb4p

Open richardclli opened this issue 1 year ago • 1 comments

Summary of changes:

  • Unified drivers for all supported Flysky radios
  • Configured NV14/EL18 in pl18 target

pl18 target and nv14 target has a lot on common, unifying them into one target can easy maintenance in the future.

This PR is based on NB4+ PR, so the merge order is:

  • NB4+ PR
  • nv14/el18 support in pl18 target PR

This branch just extend the pl18 target to handle 2 more PCBREV: nv14 and el18, i.e. one can still build nv14/el18 firmware using old target.

Old targets:

  • EL18: PCB=NV14, PCBREV=EL18
  • NV14: PCB=NV14

New targets:

  • EL18: PCB=PL18, PCBREV=EL18
  • NV14: PCB=PL18, PCBREV=NV14

richardclli avatar Aug 07 '24 05:08 richardclli

@pfeerick Please check if the tap counting problem gone with this PR.

richardclli avatar Aug 23 '24 02:08 richardclli

https://github.com/EdgeTX/edgetx/pull/5397#issuecomment-2306057149 I think the tap counting issue is till there ... IIRC, the way I was testing it was using the EventDemo Lua widget, and it won't count taps with the NV14... but is only a minor issue IMO.

Two regressions so far:

  • internal RF for NV14 appears to be be non-responsive with this PR... unable to bind a receiver, and receivers that were bound with the latest nightly are not detected. RF power option is also missing on the internal module settings settings page. Lua and external ELRS module worked though.

  • touch screen (CST836U) is unresponsive on EL18 with this PR (although tapping the screen is resetting the inactivity counter), was fine with nightly. Internal RF connected to a pre-bound receiver is working.

pfeerick avatar Jan 28 '25 01:01 pfeerick

@pfeerick I finally fixed the nv14 internal module, it is caused by a typo, haha.

richardclli avatar Feb 03 '25 07:02 richardclli

lol... ouch! no wonder it was hiding so well... it was just one teensy weensy extra letter where it wasn't wanted. Fantastic!!! I'll give it a spin shortly and hopefully merge :)

pfeerick avatar Feb 04 '25 01:02 pfeerick

Perfecto! :)

pfeerick avatar Feb 04 '25 01:02 pfeerick