edgetx icon indicating copy to clipboard operation
edgetx copied to clipboard

Slow response when changing number of points of a curve

Open fhpage opened this issue 1 year ago • 8 comments

Is there an existing issue for this problem?

  • [X] I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

Changing the number of points on a curve using either the wheel or touch commands is very slow to respond to changes. Can take several seconds (3-5). Using the roller wheel, have to turn one click and wait several seconds. Tested with 2.10.0, 2.10.2, 2.9.4. Also tested with 2 TX16S and one X10S. Not an issue with OpenTX on X12S.

Expected Behavior

The GUI should be able to follow the number of wheel clicks without stalling...

Steps To Reproduce

Use scroll (roller) wheel to change number of points on a curve.

Version

2.10.2

Transmitter

FrSky X10 / X10S (ACCST), RadioMaster TX16S / TX16SMK2

Operating System (OS)

No response

OS Version

No response

Anything else?

No response

fhpage avatar Jul 26 '24 13:07 fhpage

No problems on 2.11.0 - changing number of points takes < 0.5s

TomasJot avatar Jul 26 '24 21:07 TomasJot

This is the performance issue with the text input fields in Lvgl.

@pfeerick - is it worth trying to back port the workaround from 2.11?

philmoz avatar Jul 27 '24 00:07 philmoz

If 2.11 is a ways out to being released, a back port would be appreciated. This impacts everyone that uses curves. It is frustrating to use as is. Best alternative now is to use companion....

fhpage avatar Jul 27 '24 11:07 fhpage

Only you can answer that question Phil as you know how much code change is needed to make it work. I wonder if it is worth detaching that field so it doesn't "live update" on every field change, but rather on exit? Thus you only get one refresh update delay, not multiple as the values change? i.e popup menu instead of textedit field?

pfeerick avatar Jul 27 '24 21:07 pfeerick

It's also slow when changing from 'Standard' to 'Custom' because the point list gets rebuilt.

Back porting the 2.11 code would be a significant change (and affects all pages with text/number entry fields). Since it's not technically a bug fix I wasn't sure about trying to retro fit into 2.10.

philmoz avatar Jul 27 '24 21:07 philmoz

That was what I thought might be the case... What about simply changing the field type - to a choice/popup menu? thus it should only update once?

pfeerick avatar Jul 27 '24 21:07 pfeerick

That was what I thought might be the case... What about simply changing the field type - to a choice/popup menu? thus it should only update once?

That's probably the best option for 2.10.

I'm thinking this should also be applied to 2.11 as well for consistency.

philmoz avatar Jul 27 '24 23:07 philmoz

Agreed... Plus while 2.11 performance is better there, it is still quite laggy...

pfeerick avatar Jul 28 '24 00:07 pfeerick

Can this be closed?

philmoz avatar Sep 09 '24 12:09 philmoz

GitHub is hopeless at times... it didn't auto link/close with the PR merge.

pfeerick avatar Sep 09 '24 21:09 pfeerick