edgetx icon indicating copy to clipboard operation
edgetx copied to clipboard

fix(nv14/el18): Battery charging

Open richardclli opened this issue 1 year ago • 4 comments

This PR disables the use of direct drawing for firmware:

https://github.com/EdgeTX/edgetx/pull/5068

which breaks the charging UI in Flysky radios (NV14, EL18, PL18, PL18EV, etc.)

This PR provide a quick fix, the charging mechanism will be reworked later on according to

https://github.com/EdgeTX/edgetx/issues/2794

richardclli avatar Jun 13 '24 07:06 richardclli

Would probably be better to limit this to those radios, or even simpler, flysky radios generally, so this doesn't clash with h7 (the whole reason that other PR exists ;) )

pfeerick avatar Jun 13 '24 09:06 pfeerick

Would probably be better to limit this to those radios, or even simpler, flysky radios generally, so this doesn't clash with h7 (the whole reason that other PR exists ;) )

I already added remarks to the code, these will be reverted once the charging mechanism is reworked.

BTW, this PR fixed one more BUG introduced by obsolete-stdperiph if you take a look on what I have changed.

richardclli avatar Jun 14 '24 02:06 richardclli

I believe we can make it possible on runtime in general, with just some parameter in the LCD init. I’ll try to see if there are any conflicts that way. But clearly, we should offer a way to use LVGL proper in such applications as well (charging screen).

raphaelcoeffic avatar Jun 14 '24 07:06 raphaelcoeffic

I believe we can make it possible on runtime in general, with just some parameter in the LCD init. I’ll try to see if there are any conflicts that way. But clearly, we should offer a way to use LVGL proper in such applications as well (charging screen).

@raphaelcoeffic Any progress?

richardclli avatar Jun 24 '24 06:06 richardclli

Replaced by a better implementation: https://github.com/EdgeTX/edgetx/pull/5237

richardclli avatar Jul 02 '24 05:07 richardclli