edgetx icon indicating copy to clipboard operation
edgetx copied to clipboard

feat(bw): add radio option to invert LCD/OLED display for 128x64 B&W screens.

Open philmoz opened this issue 10 months ago • 5 comments

Tested on OLED (T14 and T20v2) and LCD (X7, MT12 and TLite).

philmoz avatar Apr 27 '24 06:04 philmoz

I moved the option to the hardware tab as suggested in discord. Thanks @pfeerick

screenshot_t20v2_24-04-28_09-48-34

philmoz avatar Apr 27 '24 23:04 philmoz

Will this be added to the final 2.10, or do I have to get the special version to get this feature?

inventor7777 avatar Apr 28 '24 17:04 inventor7777

2.10 is feature complete, so this will be in 2.11 if merged.

On Mon, 29 Apr 2024, 3:36 am inventor7777, @.***> wrote:

Will this be added to the final 2.10, or do I have to get the special version to get this feature?

— Reply to this email directly, view it on GitHub https://github.com/EdgeTX/edgetx/pull/4933#issuecomment-2081570724, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ66KN3QYSFQ7OAWF7DGXDY7UXTFAVCNFSM6AAAAABG33CLP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBRGU3TANZSGQ . You are receiving this because you were mentioned.Message ID: @.***>

pfeerick avatar Apr 28 '24 20:04 pfeerick

2.10 is feature complete, so this will be in 2.11 if merged.

Sounds good! I hope it is added eventually, because I could definitely use it.

inventor7777 avatar Apr 29 '24 21:04 inventor7777

i remembered this function has been required on discord around years ago , so happy everyone can use it now

arthurson avatar May 06 '24 12:05 arthurson

Hi, I have downloaded the build and it doesnt have persistance. I have been waiting for this and also asked on discord so it is really good feature for me and whenever I chek it and it toggles and works. BUT after I turn the radio off and then on it is not checked and not working. Tested on RadioMaster Boxer

DuckyScr avatar May 13 '24 12:05 DuckyScr

It's working on the B&W radios I have; but I don't have a boxer to test on.

Can you turn on the option and before restarting copy the RADIO/radio.yaml file off the radio. Then restart and copy the same file off the radio again. Please upload both file here in a ZIP file.

philmoz avatar May 13 '24 21:05 philmoz

Archive.zip here it is and what Ive found out is that the check button in hardware tab is still checked after restart, just the screen is not inverted and btw my sd card content is on version 2.10.0 if that helps :)

DuckyScr avatar May 14 '24 07:05 DuckyScr

Thanks for that - can you try the version in this ZIP file please.

boxer_lcdinvert_240514.bin.zip

philmoz avatar May 14 '24 07:05 philmoz

Archive.zip still the same issue, there is the yml

DuckyScr avatar May 14 '24 07:05 DuckyScr

Can you confirm - after a reboot if you turn the option off and back on then the screen inverts?

philmoz avatar May 14 '24 07:05 philmoz

Yes, that is exactly what it does

DuckyScr avatar May 14 '24 07:05 DuckyScr

Thanks.again - here's another firmware to try (no need to upload the radio.yaml files).

boxer_invert_try2.bin.zip

philmoz avatar May 14 '24 08:05 philmoz

still the same issue

DuckyScr avatar May 14 '24 08:05 DuckyScr

Working fine here, even with your radio.yml

https://photos.app.goo.gl/nBNZbu6kgghicmtF7

3djc avatar May 14 '24 09:05 3djc

And what version of sdcard content you have?

DuckyScr avatar May 14 '24 09:05 DuckyScr

It doesn't matter there, only radio and models are read at that stage, but if you post a full copy of your sd, I can try it

3djc avatar May 14 '24 09:05 3djc

Ok so I'll try to find some issues or smth that woukd cause the problem. Thanks for help :)

DuckyScr avatar May 14 '24 09:05 DuckyScr

Only one minor detail :hand_over_mouth:

  • Companion: It updates RADIO/radio.yml, but does not set the correct value. I was trying to go from inverted, back to normal, but it wrote invertLCD: 1 on the update. And same when going from normal to inverted (writes original state again). This was with a build I grabbed just before you rebased. T-Pro profile.

Everything else looks great... well, screen quality (at a budget) permitting. Boxer, TPro, TX12 (LCD) and TProV2 (OLED)

pfeerick avatar Jun 05 '24 09:06 pfeerick

  • Companion: It updates RADIO/radio.yml, but does not set the correct value. I was trying to go from inverted, back to normal, but it wrote invertLCD: 1 on the update.

Copy paste error - should be fixed now.

philmoz avatar Jun 05 '24 09:06 philmoz

Perfect, thanks! :)

pfeerick avatar Jun 05 '24 11:06 pfeerick