edgetx icon indicating copy to clipboard operation
edgetx copied to clipboard

Trainer settings per model and not system wide

Open Papa-Echo opened this issue 10 months ago • 10 comments

Is there an existing issue for this feature request?

  • [X] I have searched the existing issues

Is your feature request related to a problem?

I am the instructor in our club and I have several students for quadcopter (FPV) flying and for FPV planes. The problem is that OpenTx and Edge-TX only have one setting for Instructor/Student in the SYS menues.

Describe the solution you'd like

I want to ask for a model specific Instructor/Student page. The reason is that I teach several students on the same day. One student is a beginner and I limit his % to 50. Then I have a more advanced student who can fly with 100%. The next student comes with his own plane or quadcopter and has a different order of channels. Or the calibration needs to be changed. Every time I need to change this SYS page. It would be much better if I could set up a model for each student and set specific values for the Instructor/Student mode.

Describe alternatives you've considered

This model trainer page could be added to the first model page if Instructor is selected.

Additional context

No response

Papa-Echo avatar Apr 23 '24 02:04 Papa-Echo

Sounds like another candidate for the global/model level settings paradigm being introduced.

pfeerick avatar Apr 25 '24 01:04 pfeerick

I noted in a past that having a few system trainer configs, that could be assigned to any model would be beneficial - ie "Bobs Radio, "Sue's Radio" that then could be selected (perhaps even by a switch) for a particular model. OP carries this a step further and makes it all model specific. So a complete model for Sue and another for Bob. Can be limiting if the Instructor has several different models he will be using as a Master with the same students. (I solved the rate problem by putting "low" on a dial, and then I can adjust the actual weight in the air to what suits that student). The second example begs whether the students own plane/radio will be the master, or if the Instructor will setup and bind a new model so he can be the master. If the first case, then the setup for the slave TX has to be done in the student radio - which this proposal doesn't solve. OR beyond the work of duplicating/binding a new model in the Instructor radio, then either the OP's proposal or my variant will assist. Mine, of course, seems to follow the design parameters of keeping Sources distinct from use of those sources. Kind of like when Inputs was separated from the Mixer way, way back in the early days.

sande005 avatar May 12 '24 14:05 sande005

@sande005 the profile idea would be nice, indeed. In general, the trainer config is a bit weird right now. Parts of the settings are radio settings, some others are under model settings, and there are 5 different places to configure simple things. I'd really prefer some one-stop shop, rather than this complex setup.

raphaelcoeffic avatar May 16 '24 13:05 raphaelcoeffic

@raphaelcoeffic - I agree with you, a one-stop config is generally preferable. All of you are doing amazing work. It will be interesting to see what solutions you can come up with for this classic one-to-many and many-to-one problem! Whatever you do, rip up and throw away the current code in Companion for Trainers - it is very messed up (but was long,long ago in OpenTX also)

sande005 avatar May 16 '24 13:05 sande005

I've seen This request. I do not know whether someone is working on this. I do a lot of training of new pilots in our club for 3 years now and I had the same problems. Up to five students, different models, different radios. I solved that problem by doing the calibration of the student/spotter radios in mixers instead of using the basic radio function. The calibration in the basic function is always the same (offset=0, weight=100)

Originally I used copies of the models for different calibrations. But I ended up having a lot copies of the same models that made it difficult to keep them all updated to the same level.

Now I use only one model per plane. I do use scripts if I want to change from trainer to spotter version or from one students radio to another. (Some scripts are even automatically written by another script)

I know that this method would not be the same if you do some functionality in the basic code. But probably you could find some ideas there that could be worth thinking about.

If you are interested I would upload a description (but this would take some time, cause I've to update it to this years modifications).

ChrisOhara57 avatar Sep 10 '24 11:09 ChrisOhara57

This is a description of my workarounds.

Trainer-Student-Shortversion-English 2024-09-11.pdf

ChrisOhara57 avatar Sep 17 '24 09:09 ChrisOhara57

Hi Chris, Thank you for your input. I apologize for my late reply, but I am super busy.

Although you found a workaround for the problem I still hope that the developers take up my idea and change the EdgeTX code.

Thank you, Peter

I've seen This request. I do not know whether someone is working on this. I do a lot of training of new pilots in our club for 3 years now and I had the same problems. Up to five students, different models, different radios. I solved that problem by doing the calibration of the student/spotter radios in mixers instead of using the basic radio function. The calibration in the basic function is always the same (offset=0, weight=100)

Originally I used copies of the models for different calibrations. But I ended up having a lot copies of the same models that made it difficult to keep them all updated to the same level.

Now I use only one model per plane. I do use scripts if I want to change from trainer to spotter version or from one students radio to another. (Some scripts are even automatically written by another script)

I know that this method would not be the same if you do some functionality in the basic code. But probably you could find some ideas there that could be worth thinking about.

If you are interested I would upload a description (but this would take some time, cause I've to update it to this years modifications).

— Reply to this email directly, view it on GitHub https://github.com/EdgeTX/edgetx/issues/4916#issuecomment-2340471971, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMMLAMYYEKSZPNYH4QV2KO3ZV3M7TAVCNFSM6AAAAABGT5J7K6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBQGQ3TCOJXGE. You are receiving this because you authored the thread.Message ID: @.***>

Papa-Echo avatar Sep 19 '24 23:09 Papa-Echo

Hi Papa-Echo I do agree. While my workarounds do work perfect I found that for the average (or new user) they are still to complex to understand. We are ten OpenTX/EdgeTX user in our club and I am the only one who manage these things effortless.

Please do also have a look at my related proposal in issue #5532 Thanks you Chris

ChrisOhara57 avatar Sep 20 '24 07:09 ChrisOhara57

A very elegant, if complex solution. The one fly in the ointment - it is essentially an improved "quick take back" method. When the master moves a stick, he gets control. For those of us that "shadow fly" and keep the master sticks moving to the position they need to be in for the students current flight attitude, when master control is regained, this won't be useable. ie - student overbanks left, I move my stick right to anticipate a counter bank, but may not take control right away, as I give the student a few beats to correct on his own. It also seems to lend itself to lack of clarity about who is currently in control - say the master is at neutral, and the student hasn't done anything yet, student may be unclear that he again has control. I even have a voice prompt that announces "your plane" when I flip the switch to give the student control. But reality is I hardly ever enable it - the reassurance in my actually telling the student seems to help keep them focused.

sande005 avatar Sep 20 '24 14:09 sande005

A very elegant, if complex solution. The one fly in the ointment - it is essentially an improved "quick take back" method. When the master moves a stick, he gets control. For those of us that "shadow fly" and keep the master sticks moving to the position they need to be in for the students current flight attitude, when master control is regained, this won't be useable. ie - student overbanks left, I move my stick right to anticipate a counter bank, but may not take control right away, as I give the student a few beats to correct on his own. It also seems to lend itself to lack of clarity about who is currently in control - say the master is at neutral, and the student hasn't done anything yet, student may be unclear that he again has control. I even have a voice prompt that announces "your plane" when I flip the switch to give the student control. But reality is I hardly ever enable it - the reassurance in my actually telling the student seems to help keep them focused.

I do agree. There are more than one way of how to gain the control for the trainer. Everyone has to find out what suites him best. While the discussion on this is very interesting I would suggest to focus on the headline of this issue "Trainer settings per model and not system wide".

ChrisOhara57 avatar Sep 20 '24 17:09 ChrisOhara57