edgetx icon indicating copy to clipboard operation
edgetx copied to clipboard

feat(color): add color properties for the battery level indicator in the radio info widget.

Open philmoz opened this issue 3 months ago • 14 comments

Allow users to set the low, middle and high battery level colors.

Should these be translatable strings?

screenshot_tx16s_24-04-06_13-47-53

philmoz avatar Apr 06 '24 02:04 philmoz

Looks like we have miles of space there? So for DE:

"Farbe Akku fast leer" "Farbe Akku mittel" "Farbe Akku voll"

If there is more space maybe insert a "bei" inbetween "Farbe" and "Akku" for extra clarity.

Could we make the default "full" color depending on the theme secondary foreground (?) color (white in this case)? Green could look ugly with some themes or stick out too much visually when it doesn't need to. Battery full, all good, no need to visually alert the user?

froqstar avatar Apr 06 '24 06:04 froqstar

I have added translation strings for the widget names and settings.

#define TR_DATE_TIME_WIDGET       "Date & Time"
#define TR_RADIO_INFO_WIDGET      "Radio Info"
#define TR_LOW_BATT_COLOR         "Low battery"
#define TR_MID_BATT_COLOR         "Mid battery"
#define TR_HIGH_BATT_COLOR        "High battery"

philmoz avatar Apr 06 '24 09:04 philmoz

Should these be translatable strings?

'fraid so... and sorry for just clobbering this with your other PR :zany_face: translations seem to like to always collide

pfeerick avatar Apr 07 '24 22:04 pfeerick

SE translations #define TR_DATE_TIME_WIDGET "Datum & Tid" #define TR_RADIO_INFO_WIDGET "Radioinfo" (or if it fits "Radioinformation") #define TR_LOW_BATT_COLOR "Lågt batteri" #define TR_MID_BATT_COLOR "Medium batteri" #define TR_HIGH_BATT_COLOR "Högt batteri"

ulfhedlund avatar Apr 09 '24 18:04 ulfhedlund

Can we get some translations for this please 😃 . Will merge in seven days from this comment, regardless of translation state :hand_over_mouth:

  • [x] @zyren CN / TW
  • [x] @Eldenroot CZ
  • [x] @HThuren DA
  • [x] @froqstar DE - Just the DATE_TIME, RADIO_INFO left
  • [ ] @Pat6874 FR
  • [x] @offer-shmuely HE
  • [x] @robustini IT
  • [x] @ToshihiroMakuuchi JP
  • [x] SE
  • [x] @ajjjjjjjj PL
  • [x] @zandorsp PT
  • [x] @kobakirill RU
#define TR_DATE_TIME_WIDGET       "Date & Time"
#define TR_RADIO_INFO_WIDGET      "Radio Info"
#define TR_LOW_BATT_COLOR         "Low battery"
#define TR_MID_BATT_COLOR         "Mid battery"
#define TR_HIGH_BATT_COLOR        "High battery"

pfeerick avatar Apr 27 '24 22:04 pfeerick

DE

#define TR_DATE_TIME_WIDGET       "Datum & Uhrzeit"
#define TR_RADIO_INFO_WIDGET      "Fernst. Info"
#define TR_LOW_BATT_COLOR         "Farbe Akku fast leer"
#define TR_MID_BATT_COLOR         "Farbe Akku mittel"
#define TR_HIGH_BATT_COLOR        "Farbe Akku voll"

froqstar avatar Apr 27 '24 22:04 froqstar

DA #define TR_DATE_TIME_WIDGET "Dato & Klokke" #define TR_RADIO_INFO_WIDGET "Radio info" #define TR_LOW_BATT_COLOR "Batteri lavt" #define TR_MID_BATT_COLOR "Batteri medio" #define TR_HIGH_BATT_COLOR "Batteri højt"

HThuren avatar Apr 27 '24 22:04 HThuren

HE

#define TR_DATE_TIME_WIDGET "תאריך ושעה" #define TR_RADIO_INFO_WIDGET "מידע השלט" #define TR_LOW_BATT_COLOR "מתח סוללה נמוך" #define TR_MID_BATT_COLOR "מתח סוללה בינוני" #define TR_HIGH_BATT_COLOR "מתח סוללה גבוה"

offer-shmuely avatar Apr 27 '24 23:04 offer-shmuely

PT

#define TR_DATE_TIME_WIDGET       "Data & Hora"
#define TR_RADIO_INFO_WIDGET      "Inf do Rádio"
#define TR_LOW_BATT_COLOR         "Bateria Baixa"
#define TR_MID_BATT_COLOR         "Bateria Média"
#define TR_HIGH_BATT_COLOR        "Bateria Alta"

zandorsp avatar Apr 28 '24 01:04 zandorsp

IT

#define TR_DATE_TIME_WIDGET "Data & Ora" #define TR_RADIO_INFO_WIDGET "Radio Info" #define TR_LOW_BATT_COLOR "Batteria bassa" #define TR_MID_BATT_COLOR "Batteria media" #define TR_HIGH_BATT_COLOR "Batteria alta"

In Italian low (bassa), mid (media) and high (alta) are never related to the state of a battery, but to a position in space. So better alternative for IT:

#define TR_LOW_BATT_COLOR "Batteria scarica" #define TR_MID_BATT_COLOR "Batteria media" #define TR_HIGH_BATT_COLOR "Batteria carica"

robustini avatar Apr 28 '24 09:04 robustini

CN

#define TR_DATE_TIME_WIDGET       "日期和时间"
#define TR_RADIO_INFO_WIDGET      "遥控器信息"
#define TR_LOW_BATT_COLOR         "低电量"
#define TR_MID_BATT_COLOR         "中电量"
#define TR_HIGH_BATT_COLOR        "高电量"

TW

#define TR_DATE_TIME_WIDGET       "日期和時間"
#define TR_RADIO_INFO_WIDGET      "遙控器信息"
#define TR_LOW_BATT_COLOR         "低電量"
#define TR_MID_BATT_COLOR         "中電量"
#define TR_HIGH_BATT_COLOR        "高電量"

zyren avatar Apr 28 '24 14:04 zyren

CZ

#define TR_DATE_TIME_WIDGET "Datum a čas" #define TR_RADIO_INFO_WIDGET "Informace o vysílačce" #define TR_LOW_BATT_COLOR "Vybitá baterie" #define TR_MID_BATT_COLOR "Středně nabitá baterie" #define TR_HIGH_BATT_COLOR "Plně nabitá baterie"

Eldenroot avatar Apr 28 '24 18:04 Eldenroot

JP

#define TR_DATE_TIME_WIDGET "日付と時刻" #define TR_RADIO_INFO_WIDGET "送信機情報" #define TR_LOW_BATT_COLOR "バッテリー低" #define TR_MID_BATT_COLOR "バッテリー中" #define TR_HIGH_BATT_COLOR "バッテリー高"

ToshihiroMakuuchi avatar May 04 '24 02:05 ToshihiroMakuuchi

PL

#define TR_DATE_TIME_WIDGET       "Data i czas"
#define TR_RADIO_INFO_WIDGET      "Informacje o radiu"
#define TR_LOW_BATT_COLOR         "Rozładowana bateria"
#define TR_MID_BATT_COLOR         "Średni stan baterii"
#define TR_HIGH_BATT_COLOR        "Naładowana bateria"

ajjjjjjjj avatar May 05 '24 09:05 ajjjjjjjj

#define TR_DATE_TIME_WIDGET "Дата и время" #define TR_RADIO_INFO_WIDGET "Инфо о пульте" #define TR_LOW_BATT_COLOR "Разряженная АКБ" #define TR_MID_BATT_COLOR "Середина АКБ " #define TR_HIGH_BATT_COLOR "Заряженная АКБ"

kobakirill avatar May 06 '24 09:05 kobakirill