edgetx icon indicating copy to clipboard operation
edgetx copied to clipboard

Unable to switch between numbers and variables

Open chofchop opened this issue 1 year ago • 26 comments

Is there an existing issue for this problem?

  • [X] I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

For example, input>TH>Weight, it is not possible to switch between numerical values ​​and variables.

Expected Behavior

Pressing and holding Enter on this item switches the numerical value <> variable.

Steps To Reproduce

Even if you try to switch between numbers and variables in an item that can use them, it will not work.

Version

Other (Please specify below)

Transmitter

RadioMaster MT12

Operating System (OS)

No response

OS Version

No response

Anything else?

I don't know when this phenomenon started occurring, but it has not occurred as of 1b7044a1.

chofchop avatar Feb 21 '24 13:02 chofchop

Just tested current nighties, works normally

image

image

3djc avatar Feb 21 '24 15:02 3djc

Works correctly on the shipping MT12 firmware as well in my testing

mawzthefinn avatar Feb 21 '24 15:02 mawzthefinn

Works correctly on the shipping MT12 firmware as well in my testing

Hello. I also have no problems with the 1b7044a firmware (January 17th). I'm converting my display to OLED, so is there any possibility that this may be causing the problem?

chofchop avatar Feb 21 '24 16:02 chofchop

After deleting radio.yml, normal operation returned. When I restore the backed up radio.yml, the problem occurs again. I'll do a little more research to find out what the problem is.

chofchop avatar Feb 23 '24 01:02 chofchop

It turns out that the direct cause of this problem is in radio.yml. Probably with firmware after dfaad73,

modelGVDisabled: 0 > No problem modelGVDisabled: 1 > Can't switch value <> variable

There is no GVDisabled checkbox in RADIO SETUP, so it cannot be changed. If edit radio.yml directly, it will not start with "Missing or bad radio data".

2024-02-23 175504 2024-02-23 16 38 24

chofchop avatar Feb 23 '24 09:02 chofchop

Well makes sense, if GV are disabled, you cannot use those. The question is how did you get it there . have you disabled GV screen in radio or model setup ?

3djc avatar Feb 23 '24 09:02 3djc

I actively use GVAR, so I never intentionally disable it. As mentioned earlier, there is no checkbox for GVDisabesd in RADIO SETUP. Is it in MODEL SETUP? I started using MT12 two months ago. I've been using the same model data and radio setup ever since. Isn't it possible that it was set to DVDisabled by default back then?

chofchop avatar Feb 23 '24 09:02 chofchop

Is it correct that there is no GVDisabled checkbox in RADIO SETUP? How do I set GVDisabled to 0 in radio.yml?

chofchop avatar Feb 23 '24 10:02 chofchop

It is only available in colorlcd UI, did you go through that at some point ?

3djc avatar Feb 23 '24 10:02 3djc

No, the only radios I own are the X9Lite and MT12.

chofchop avatar Feb 23 '24 10:02 chofchop

When github will have compiled #4671, could you try produced firmware ?

3djc avatar Feb 23 '24 10:02 3djc

You can now get it at: https://github.com/EdgeTX/edgetx/actions/runs/8018181460/artifacts/1269425993

3djc avatar Feb 23 '24 11:02 3djc

I compiled #4671 with gitpod (55ea148c). A checkbox for GROVAL VARIABLES has appeared in RADIO SETUP, but it is still not possible to switch between numbers and variables. I haven't tested it enough yet, so I'll try it some more.

chofchop avatar Feb 23 '24 11:02 chofchop

Global variable need to be active (either through model or radio), but it works here if active (and doesn't if disabled, as expected)

3djc avatar Feb 23 '24 11:02 3djc

I tried various things and now it works. Just flashing 55ea148 didn't work. Once I deleted radio.yml and redid the setup, I was able to activate GVAR on each model. It's good that the problem has been resolved, but it takes a lot of effort to redo RADIO SETUP....

I have a question. GVAR on/off seems to be saved for each model data, but there is only one GVDisabled in radio.yml. Where is GVAR on/off saved for each model?

chofchop avatar Feb 23 '24 13:02 chofchop

Model-specific data is always in the modelxx.yml file for the model.

mawzthefinn avatar Feb 23 '24 13:02 mawzthefinn

Like all the options, you can choose in your model if you obey radio settings or specific for this model. There as probably no need to redo the radio.yml, you need to understand better how those work

3djc avatar Feb 23 '24 13:02 3djc

Like all the options, you can choose in your model if you obey radio settings or specific for this model.

I don't fully understand it yet, but I found it.

2024-02-23 230923

chofchop avatar Feb 23 '24 14:02 chofchop

There as probably no need to redo the radio.yml, you need to understand better how those work

With my current skills, I could only delete it. I don't want to delete it either, so I'll study it more.

chofchop avatar Feb 23 '24 14:02 chofchop

Sorry for the late reply, but thank you for resolving the issue.

chofchop avatar Feb 23 '24 14:02 chofchop

Set it to global

3djc avatar Feb 23 '24 14:02 3djc

Yes, I intentionally changed it from GLOBAL to OFF.

chofchop avatar Feb 23 '24 14:02 chofchop

I will ask the remaining questions in the RC groups MT12 thread.

chofchop avatar Feb 23 '24 15:02 chofchop

I have summarized the history so far.

1.For some reason, GVDisabled in my radio.yml was set to 1. At this point, the firmware was ignoring GVDisabled, so there was no problem. 2.Since dfaad73, the firmware no longer ignores GVDisabled in radio.yml. At this point I can no longer use GVAR. 3.GVAR checkbox was added to RADIO SETUP in #4671, but this operates on GVDisabled in modelxx.yml, so I still cannot use GVAR. 4.I manually edited GVDisabled in radio.yml to 0. I am now finally able to use GVAR.

In my opinion, the GVAR checkbox in RADIO SETUP should operate on radio.yml. If GVAR need to turn on/off for each model data, I think the checkbox should provide in MODEL SETUP.

chofchop avatar Feb 25 '24 07:02 chofchop

After discussion, we have decided to prevent disabling GVAR on 128 for now. PR has been updated accordingly

3djc avatar Feb 25 '24 13:02 3djc

That's good.

chofchop avatar Feb 25 '24 14:02 chofchop